Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree-view: Always show PodGroup in replicaset when Child Pod node exist #12051

Closed
ashutosh16 opened this issue Jan 19, 2023 · 2 comments · Fixed by #12065
Closed

Tree-view: Always show PodGroup in replicaset when Child Pod node exist #12051

ashutosh16 opened this issue Jan 19, 2023 · 2 comments · Fixed by #12065
Assignees
Labels
enhancement New feature or request

Comments

@ashutosh16
Copy link
Contributor

ashutosh16 commented Jan 19, 2023

Summary

In the Tree View, when the user clicks on the group node, the last node shows as a replicaset that groups the same kind of sibling (replicaset).

This UI experience seems inconsistent. When multiple replicaset nodes exist, it displays node groups of the same kind, in this case replicaset, whereas when only one replicaset node exists, it displays podGroup.

Consistent UI experience should be provided where the user always sees podGroup on replicaset whenever child pods exist.

Current UI - when multiple replicaset nodes exist

Screen Shot 2023-01-19 at 10 35 30 AM

Current UI - When only one replica set node exists, UI shows pod group.

Screen Shot 2023-01-19 at 10 37 19 AM

The enhancement should expand the replicaset in podGroup view when child pod exists and group the sibling node when no further child node exists

@ashutosh16 ashutosh16 added the enhancement New feature or request label Jan 19, 2023
@keithchong keithchong self-assigned this Jan 20, 2023
@keithchong
Copy link
Contributor

keithchong commented Jan 20, 2023

The current behaviour is implemented as designed from point 10 from PR #8661
The grouped nodes have always taken precedent, but I can see the benefit of special-casing the replicasets and pulling them out as a pod group.

Three RS, but one RS with at least one pod:
Screen Shot 2023-01-20 at 12 00 38 PM

...and with Group Nodes enabled:
Screen Shot 2023-01-20 at 12 00 54 PM

Note the other situation where only one RS has no associated pods:
Screen Shot 2023-01-20 at 11 59 12 AM

...and with Group Nodes enabled:
Screen Shot 2023-01-20 at 11 59 27 AM

@ashutosh16
Copy link
Contributor Author

@keithchong Thanks for looking into it.
UX seems right to me ( pic 2 & 3). This would be a special case when RS is expanded as podGroup when child pod exit

keithchong added a commit to keithchong/argo-cd that referenced this issue Jan 20, 2023
Signed-off-by: Keith Chong <kykchong@redhat.com>
rbreeze added a commit that referenced this issue Jan 25, 2023

Signed-off-by: Keith Chong <kykchong@redhat.com>
Co-authored-by: Remington Breeze <remington@breeze.software>
emirot pushed a commit to emirot/argo-cd that referenced this issue Jan 27, 2023
…j#12065)

Signed-off-by: Keith Chong <kykchong@redhat.com>
Co-authored-by: Remington Breeze <remington@breeze.software>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this issue Mar 14, 2023
…j#12065)

Signed-off-by: Keith Chong <kykchong@redhat.com>
Co-authored-by: Remington Breeze <remington@breeze.software>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants