feat: Always Show ReplicaSets as Pod Groups (#12051) #12065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 47.41% // Head: 47.41% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #12065 +/- ##
=======================================
Coverage 47.41% 47.41%
=======================================
Files 246 246
Lines 41815 41815
=======================================
Hits 19825 19825
Misses 19994 19994
Partials 1996 1996 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Verified in my local and changes looks good |
ashutosh16
reviewed
Jan 20, 2023
ui/src/app/applications/components/application-resource-tree/application-resource-tree.tsx
Show resolved
Hide resolved
ashutosh16
reviewed
Jan 20, 2023
ui/src/app/applications/components/application-resource-tree/application-resource-tree.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong
force-pushed
the
12051-OverrideGroupNodesAndShowReplicaSetAsPodGroup
branch
from
07da7f2 to
2f38abf
Compare
|
Hi @rbreeze , I got a LGTM from Ashutosh. Could you please approve this? |
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
…j#12065) Signed-off-by: Keith Chong <kykchong@redhat.com> Co-authored-by: Remington Breeze <remington@breeze.software> Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
…j#12065) Signed-off-by: Keith Chong <kykchong@redhat.com> Co-authored-by: Remington Breeze <remington@breeze.software> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keith Chong kykchong@redhat.com
Fixes #12051
See screenshots of expected behavior in the above issue.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: