Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make external url's printed as list instead of one line #17679

Closed
Hronom opened this issue Apr 1, 2024 · 5 comments · Fixed by #18768
Closed

Make external url's printed as list instead of one line #17679

Hronom opened this issue Apr 1, 2024 · 5 comments · Fixed by #18768
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request good first issue Good for newcomers

Comments

@Hronom
Copy link
Contributor

Hronom commented Apr 1, 2024

Summary

Right now external url's on application details page under URL's section printed in one line:

I would like to see them printed same as urls in links section:
image

So if you have several external url's they will be printed like this:

https://example.com https://example2.com https://example3.com

Expected to see instead a list:

* https://example.com 
* https://example2.com 
* https://example3.com

Motivation

External urls created from resources that annotated in special way, potentially this resources can be inside helm and urls can be generated using all power of template in helm - this have more advantages over links and templating available there(example where links fail #17552)

This is very useful especially when you use Argo CD application details page to show details about microservice, like have links to the metrics, logs etc.

And having them as list(same as links) will increase readability when you have several of them.

@Hronom Hronom added the enhancement New feature or request label Apr 1, 2024
@jgwest jgwest added the component:ui User interfaces bugs and enhancements label Apr 2, 2024
@Killpit
Copy link

Killpit commented Apr 8, 2024

That'd be a really good addition to ArgoCD, otherwise, the code can be cluttered.

@pasha-codefresh pasha-codefresh added the good first issue Good for newcomers label May 22, 2024
@JessieTeng89
Copy link
Contributor

I will work on it and create a PR later

@Hronom
Copy link
Contributor Author

Hronom commented May 28, 2024

@JessieTeng89 thank you a lot!
It will be good if you can also take this one #17680 they will work really nice together. With this two features external urls becomes complete useful feature

pasha-codefresh pushed a commit that referenced this issue Jun 24, 2024
* break external links to lines for each

Signed-off-by: Jessie Teng <jessie.teng@fmr.com>

* update for better layout css style

Signed-off-by: Jessie Teng <jessie.teng@fmr.com>

---------

Signed-off-by: Jessie Teng <jessie.teng@fmr.com>
Co-authored-by: Jessie Teng <jessie.teng@fmr.com>
ggjulio pushed a commit to ggjulio/argo-cd that referenced this issue Jul 21, 2024
…oproj#18768)

* break external links to lines for each

Signed-off-by: Jessie Teng <jessie.teng@fmr.com>

* update for better layout css style

Signed-off-by: Jessie Teng <jessie.teng@fmr.com>

---------

Signed-off-by: Jessie Teng <jessie.teng@fmr.com>
Co-authored-by: Jessie Teng <jessie.teng@fmr.com>
jsolana pushed a commit to jsolana/argo-cd that referenced this issue Jul 24, 2024
…oproj#18768)

* break external links to lines for each

Signed-off-by: Jessie Teng <jessie.teng@fmr.com>

* update for better layout css style

Signed-off-by: Jessie Teng <jessie.teng@fmr.com>

---------

Signed-off-by: Jessie Teng <jessie.teng@fmr.com>
Co-authored-by: Jessie Teng <jessie.teng@fmr.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
@Hronom
Copy link
Contributor Author

Hronom commented Aug 12, 2024

Hello, @jsolana and @pasha-codefresh do you have sense when it will be released?

@Hronom
Copy link
Contributor Author

Hronom commented Aug 30, 2024

When it will be released? It closed long time ago and PR merged to master #18768, but it still not present in latest version?

Small change that helps a lot, but it delayed a lot, I'm a little frustrated and confused here. Seems like issue in the process of how Argo CD manage changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants