-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make external url's printed as list instead of one line #17679
Comments
That'd be a really good addition to ArgoCD, otherwise, the code can be cluttered. |
I will work on it and create a PR later |
@JessieTeng89 thank you a lot! |
* break external links to lines for each Signed-off-by: Jessie Teng <jessie.teng@fmr.com> * update for better layout css style Signed-off-by: Jessie Teng <jessie.teng@fmr.com> --------- Signed-off-by: Jessie Teng <jessie.teng@fmr.com> Co-authored-by: Jessie Teng <jessie.teng@fmr.com>
…oproj#18768) * break external links to lines for each Signed-off-by: Jessie Teng <jessie.teng@fmr.com> * update for better layout css style Signed-off-by: Jessie Teng <jessie.teng@fmr.com> --------- Signed-off-by: Jessie Teng <jessie.teng@fmr.com> Co-authored-by: Jessie Teng <jessie.teng@fmr.com>
…oproj#18768) * break external links to lines for each Signed-off-by: Jessie Teng <jessie.teng@fmr.com> * update for better layout css style Signed-off-by: Jessie Teng <jessie.teng@fmr.com> --------- Signed-off-by: Jessie Teng <jessie.teng@fmr.com> Co-authored-by: Jessie Teng <jessie.teng@fmr.com> Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
Hello, @jsolana and @pasha-codefresh do you have sense when it will be released? |
When it will be released? It closed long time ago and PR merged to master #18768, but it still not present in latest version? Small change that helps a lot, but it delayed a lot, I'm a little frustrated and confused here. Seems like issue in the process of how Argo CD manage changes... |
Summary
Right now external url's on application details page under
URL's
section printed in one line:I would like to see them printed same as urls in
links
section:So if you have several external url's they will be printed like this:
Expected to see instead a list:
Motivation
External urls created from resources that annotated in special way, potentially this resources can be inside helm and urls can be generated using all power of template in helm - this have more advantages over
links
and templating available there(example where links fail #17552)This is very useful especially when you use Argo CD application
details
page to show details about microservice, like have links to the metrics, logs etc.And having them as list(same as
links
) will increase readability when you have several of them.The text was updated successfully, but these errors were encountered: