fix(ui): break external links to lines for each (#17679) #18768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 28, 2024 14:04
Signed-off-by: Jessie Teng <jessie.teng@fmr.com>
Signed-off-by: Jessie Teng <jessie.teng@fmr.com>
…/argoproj-argo-cd into break-external-links Signed-off-by: Jessie Teng <jessie.teng@fmr.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
crenshaw-dev
changed the title
crenshaw-dev
changed the title
pasha-codefresh
approved these changes
Jun 24, 2024
|
when this will be released? |
ggjulio
pushed a commit
to ggjulio/argo-cd
that referenced
this pull request
Jul 21, 2024
…oproj#18768) * break external links to lines for each Signed-off-by: Jessie Teng <jessie.teng@fmr.com> * update for better layout css style Signed-off-by: Jessie Teng <jessie.teng@fmr.com> --------- Signed-off-by: Jessie Teng <jessie.teng@fmr.com> Co-authored-by: Jessie Teng <jessie.teng@fmr.com>
jsolana
pushed a commit
to jsolana/argo-cd
that referenced
this pull request
Jul 24, 2024
…oproj#18768) * break external links to lines for each Signed-off-by: Jessie Teng <jessie.teng@fmr.com> * update for better layout css style Signed-off-by: Jessie Teng <jessie.teng@fmr.com> --------- Signed-off-by: Jessie Teng <jessie.teng@fmr.com> Co-authored-by: Jessie Teng <jessie.teng@fmr.com> Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Break lines for external links for better user experience
Fixes #17679
Before change:
After change:
