Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): allow sorting the application list (#4060) #11645

Merged
merged 10 commits into from
Jan 25, 2023
Merged

feat(ui): allow sorting the application list (#4060) #11645

merged 10 commits into from
Jan 25, 2023

Conversation

alexef
Copy link
Member

@alexef alexef commented Dec 10, 2022 •
edited
Loading

Screenshot 2022-12-10 at 06 57 31

Screen.Recording.2022-12-10.at.06.51.35.mov

replaces: #6217

fixes: #4060

Signed-off-by: Alex Eftimie alex.eftimie@getyourguide.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@alexef
feat(ui): allow sorting the application list
3cb51e4 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@alexef alexef added the component:ui User interfaces bugs and enhancements label Dec 10, 2022
@alexef alexef requested review from alexmt and rbreeze December 10, 2022 05:59
@alexef alexef added the enhancement New feature or request label Dec 10, 2022
@alexef
Copy link
Member Author

alexef commented Dec 10, 2022

I've tested the other use cases for Paginate (Application Details/Resource List/Grouped List) and they remain unchanged)

@codecov
Copy link

codecov bot commented Dec 10, 2022 •
edited
Loading

Codecov Report

Base: 47.41% // Head: 47.38% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (4d4e1c8) compared to base (3da1eaa).
Patch has no changes to coverable lines.

❗ Current head 4d4e1c8 differs from pull request most recent head 1d48bb3. Consider uploading reports for the commit 1d48bb3 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11645      +/-   ##
==========================================
- Coverage   47.41%   47.38%   -0.03%     
==========================================
  Files         246      245       -1     
  Lines       41815    41670     -145     
==========================================
- Hits        19825    19745      -80     
+ Misses      19994    19937      -57     
+ Partials     1996     1988       -8
Impacted Files Coverage Δ
server/server.go 54.03% <0.00%> (-2.47%) ⬇️
util/session/sessionmanager.go 73.29% <0.00%> (-1.46%) ⬇️
controller/appcontroller.go 51.88% <0.00%> (-0.40%) ⬇️
util/security/jwt.go
util/settings/settings.go 48.42% <0.00%> (+0.14%) ⬆️
util/oidc/oidc.go 57.77% <0.00%> (+0.33%) ⬆️
server/application/terminal.go 20.64% <0.00%> (+1.16%) ⬆️
util/oidc/provider.go 54.54% <0.00%> (+18.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ashutosh16
ashutosh16 reviewed Dec 11, 2022
View reviewed changes
ui/src/app/applications/components/applications-list/applications-list.tsx
compare: (a, b) => a.metadata.creationTimestamp.localeCompare(b.metadata.creationTimestamp)
},
{
title: 'Synchronized',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to change Synchronized to App Health?

Copy link
Member Author

@alexef alexef Dec 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I would keep Synchronized as it is (it's the last time the sync operation finished - either successfully or not).

But an App Health sort order option makes sense as well: show Unknown,Out of sync, Synced in this order!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@alexef alexef requested a review from ashutosh16 December 12, 2022 09:48
@crenshaw-dev crenshaw-dev added this to the v2.7 milestone Dec 16, 2022
rbreeze
rbreeze approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexef
Copy link
Member Author

alexef commented Jan 16, 2023

@rbreeze / @alexmt can we merge this?

@rbreeze rbreeze enabled auto-merge (squash) January 25, 2023 17:14
@rbreeze rbreeze merged commit f7011f6 into argoproj:master Jan 25, 2023
@alexef alexef deleted the sort-options branch January 25, 2023 19:54
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
@alexef @rbreeze @emirot
feat(ui): allow sorting the application list (argoproj#11645)
9fa1264 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Co-authored-by: Remington Breeze <remington@breeze.software>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
@alexef @rbreeze @schakrad
feat(ui): allow sorting the application list (argoproj#11645)
44f7465 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Co-authored-by: Remington Breeze <remington@breeze.software>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
@crenshaw-dev crenshaw-dev mentioned this pull request May 29, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbreeze rbreeze rbreeze approved these changes

@alexmt alexmt Awaiting requested review from alexmt

@ashutosh16 ashutosh16 Awaiting requested review from ashutosh16

Assignees
No one assigned
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request
Projects
Argo CD Roadmap
Status: Completed
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.

Add support for sorting applications by name
4 participants
@alexef @rbreeze @ashutosh16 @crenshaw-dev