Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add option to sort applications list by name and deploy time #6217

Closed
wants to merge 10 commits into from

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented May 12, 2021

Screen Shot 2022-02-18 at 12 23 19

Fixes #4060

Signed-off-by: Remington Breeze remington@breeze.software

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

… time

Signed-off-by: Remington Breeze <remington@breeze.software>
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #6217 (4dc1d77) into master (d7fbc91) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6217   +/-   ##
=======================================
  Coverage   42.43%   42.43%           
=======================================
  Files         176      176           
  Lines       22889    22889           
=======================================
  Hits         9713     9713           
  Misses      11790    11790           
  Partials     1386     1386           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7fbc91...4dc1d77. Read the comment docs.

@rbreeze rbreeze requested a review from alexmt June 23, 2021 21:49
rbreeze added 5 commits July 12, 2021 10:17
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Notificed couple things that can be improved:

  • icons/checkboxes and corresponding text are not on the same line
  • checkboxes should be radio buttons instead since user cannot sort but both at the same time

image

What do you think about moving sort options to Sort by dropdown next to Items per page dropdown?

@rbreeze
Copy link
Member Author

rbreeze commented Jul 13, 2021

I think next to items-per-page is a good location for Sort By options. However, right now the items-per-page dropdown is part of a shared component, so it would require refactoring that component to put a dropdown there.

I changed the options to radio buttons, and they now change appearance based on screen size. What do you think?

Screen Shot 2021-07-13 at 2 58 01 PM

Screen Shot 2021-07-13 at 3 00 36 PM

rbreeze added 3 commits July 13, 2021 15:01
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@pasha-codefresh
Copy link
Member

I am not sure that it is usable in terms of UI, maybe better put it on top of filters as you did before just in some better way?

Снимок экрана 2022-02-20 в 16 29 45

In same style as we have for filters

WHYT @rbreeze

@pasha-codefresh pasha-codefresh added the lifecycle/rotten Issue/PR had no activity for a long time and should be closed soon label Mar 13, 2022
@dhirschfeld
Copy link

I think this would be a great improvement to the UI (even if not perfect yet).

Is there anything remaining to be addressed before this can be merged?

@alexef
Copy link
Member

alexef commented Dec 9, 2022

@rbreeze I'm also interested in this, can I help rebase/bring it back to life?

}
return 1;
}) as AppSorter,
'Deployment Time': ((a, b) => (a.status.observedAt < b.status.observedAt ? 1 : -1)) as AppSorter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the ApplicationStatus.ObservedAt field has been deprecated, probably ApplicationStatus.OperationState.FinishedAt would be a better replacement?

@crenshaw-dev
Copy link
Member

@alexef was this superseded by #11645?

@alexef
Copy link
Member

alexef commented May 30, 2023

@crenshaw-dev yes, and there was a follow up also charging the default order.

I believe this PR can be closed.

@alexef alexef closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Issue/PR had no activity for a long time and should be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for sorting applications by name
6 participants