-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Add option to sort applications list by name and deploy time #6217
Conversation
… time Signed-off-by: Remington Breeze <remington@breeze.software>
Codecov Report
@@ Coverage Diff @@
## master #6217 +/- ##
=======================================
Coverage 42.43% 42.43%
=======================================
Files 176 176
Lines 22889 22889
=======================================
Hits 9713 9713
Misses 11790 11790
Partials 1386 1386 Continue to review full report at Codecov.
|
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Notificed couple things that can be improved:
- icons/checkboxes and corresponding text are not on the same line
- checkboxes should be radio buttons instead since user cannot sort but both at the same time
What do you think about moving sort options to Sort by
dropdown next to Items per page
dropdown?
I think next to items-per-page is a good location for Sort By options. However, right now the items-per-page dropdown is part of a shared component, so it would require refactoring that component to put a dropdown there. I changed the options to radio buttons, and they now change appearance based on screen size. What do you think? |
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
I am not sure that it is usable in terms of UI, maybe better put it on top of filters as you did before just in some better way? In same style as we have for filters WHYT @rbreeze |
I think this would be a great improvement to the UI (even if not perfect yet). Is there anything remaining to be addressed before this can be merged? |
@rbreeze I'm also interested in this, can I help rebase/bring it back to life? |
} | ||
return 1; | ||
}) as AppSorter, | ||
'Deployment Time': ((a, b) => (a.status.observedAt < b.status.observedAt ? 1 : -1)) as AppSorter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the ApplicationStatus.ObservedAt
field has been deprecated, probably ApplicationStatus.OperationState.FinishedAt
would be a better replacement?
@crenshaw-dev yes, and there was a follow up also charging the default order. I believe this PR can be closed. |
Fixes #4060
Signed-off-by: Remington Breeze remington@breeze.software
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: