Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: values should always be visible, even when they are empty (#11676) #11681

Merged
merged 7 commits into from
Jan 18, 2023
Merged

fix: values should always be visible, even when they are empty (#11676) #11681

merged 7 commits into from
Jan 18, 2023

Conversation

alexef
Copy link
Member

@alexef alexef commented Dec 13, 2022

fixes: #11676

Signed-off-by: Alex Eftimie alex.eftimie@getyourguide.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@alexef
fix: values should always be visible, even when they are empty (argop…
33d1cf6 
…roj#11676)

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@alexef alexef requested a review from rbreeze December 13, 2022 08:22
@alexef alexef added this to the v2.6 milestone Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022 •
edited
Loading

Codecov Report

Base: 47.29% // Head: 47.29% // No change to project coverage 👍

Coverage data is based on head (4e308af) compared to base (c31d15e).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11681   +/-   ##
=======================================
  Coverage   47.29%   47.29%           
=======================================
  Files         245      245           
  Lines       41670    41670           
=======================================
  Hits        19707    19707           
  Misses      19978    19978           
  Partials     1985     1985

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexef alexef added the breaking/low A possibly breaking change with low impact label Dec 14, 2022
@alexef alexef requested a review from crenshaw-dev December 15, 2022 09:01
@crenshaw-dev
Merge branch 'master' into fix-values-edit
8d3daed 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Copy link
Member

@alexef with removal of the expandable, are we going to end up with very very large values blocks taking too much vertical UI space?

@alexef
Copy link
Member Author

alexef commented Dec 21, 2022 •
edited
Loading

@crenshaw-dev no, the expendable doesn't make sense there. it's already present on view, we shouldn't be additionally showing it on edit

@alexef alexef added bug/severity:minor Bug has limited impact, maybe affects only an edge-case or is of cosmetic nature and removed breaking/low A possibly breaking change with low impact labels Jan 16, 2023
@crenshaw-dev crenshaw-dev merged commit 1808539 into argoproj:master Jan 18, 2023
crenshaw-dev added a commit that referenced this pull request Jan 18, 2023
@alexef @crenshaw-dev
fix: values should always be visible, even when they are empty (#11676)…
2266255 
… (#11681)

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Copy link
Member

Cherry-picked onto release-2.6 for 2.6.0-rc5.

@alexef would you mind opening a PR to apply the change to the release-2.5 branch? I'm getting conflicts and am scared of frontend surgery.

@alexef alexef deleted the fix-values-edit branch January 18, 2023 15:07
@alexef
Copy link
Member Author

alexef commented Jan 18, 2023

I don't mind, will do

@alexef alexef mentioned this pull request Jan 25, 2023
Merged
10 tasks
@alexef
Copy link
Member Author

alexef commented Jan 25, 2023

sorry for the delay: #12139

emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
@alexef @crenshaw-dev @emirot
fix: values should always be visible, even when they are empty (argop…
1f203e6 
…roj#11676) (argoproj#11681)

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Jan 31, 2023
@alexef
fix: backport values should always be visible on 2.5 (#11681) (#12139)
b413afd 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
@alexef @crenshaw-dev @schakrad
fix: values should always be visible, even when they are empty (argop…
0b4ad74 
…roj#11676) (argoproj#11681)

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@rbreeze rbreeze Awaiting requested review from rbreeze

Assignees
No one assigned
Labels
bug/severity:minor Bug has limited impact, maybe affects only an edge-case or is of cosmetic nature cherry-pick/2.5 cherry-pick/2.6
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.

Parameters > Values text entry broken for applications without existing values by #11316
2 participants
@alexef @crenshaw-dev