fix: backport values should always be visible on 2.5 (#11681) (#12139)

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
argoproj · Jan 31, 2023 · b413afd · b413afd
1 parent 702082e
commit b413afd
Showing 1 changed file with 15 additions and 25 deletions.
diff --git a/ui/src/app/applications/components/application-parameters/application-parameters.tsx b/ui/src/app/applications/components/application-parameters/application-parameters.tsx
@@ -190,31 +190,21 @@ export const ApplicationParameters = (props: {
                 />
             )
         });
-        if (app?.spec?.source?.helm?.values) {
-            attributes.push({
-                title: 'VALUES',
-                view: app.spec.source.helm && (
-                    <Expandable>
-                        <pre>{app.spec.source.helm.values}</pre>
-                    </Expandable>
-                ),
-                edit: (formApi: FormApi) => (
-                    <div>
-                        <pre>
-                            <FormField formApi={formApi} field='spec.source.helm.values' component={TextArea} />
-                        </pre>
-                        {props.details.helm.values && (
-                            <div>
-                                <label>values.yaml</label>
-                                <Expandable>
-                                    <pre>{props.details.helm.values}</pre>
-                                </Expandable>
-                            </div>
-                        )}
-                    </div>
-                )
-            });
-        }
+        attributes.push({
+            title: 'VALUES',
+            view: app.spec.source.helm && (
+                <Expandable>
+                    <pre>{app.spec.source.helm.values}</pre>
+                </Expandable>
+            ),
+            edit: (formApi: FormApi) => (
+                <div>
+                    <pre>
+                        <FormField formApi={formApi} field='spec.source.helm.values' component={TextArea} />
+                    </pre>
+                </div>
+            )
+        });
         const paramsByName = new Map<string, models.HelmParameter>();
         (props.details.helm.parameters || []).forEach(param => paramsByName.set(param.name, param));
         const overridesByName = new Map<string, number>();