Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement graceful shutdown in application-controller #19465

Merged
merged 10 commits into from
Aug 11, 2024
Merged

feat: Implement graceful shutdown in application-controller #19465

merged 10 commits into from
Aug 11, 2024

Conversation

leehosu
Copy link
Member

@leehosu leehosu commented Aug 10, 2024

summary

Add logic to verify Gracefulshutdown.

before

스크린샷 2024-08-10 오후 4 23 40

after

스크린샷 2024-08-10 오후 4 36 07

related #18642

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

leehosu added 4 commits August 10, 2024 15:28
@leehosu
Implement graceful shutdown in argocd-application-controller
e6300a1 
Signed-off-by: leehosu <hosu4549@gmail.com>
@leehosu
Implement code to pass waitGroup to Run function
13562d0 
Signed-off-by: leehosu <hosu4549@gmail.com>
@leehosu
Add retuen nil
a955aa5 
Signed-off-by: leehosu <hosu4549@gmail.com>
@leehosu
Add log for lean shutdown
710cfad 
Signed-off-by: leehosu <hosu4549@gmail.com>
@leehosu leehosu requested a review from a team as a code owner August 10, 2024 07:37
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 10, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 10, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@leehosu leehosu changed the title Feat: Implement graceful shutdown in application-controller feat: Implement graceful shutdown in application-controller Aug 10, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.87%. Comparing base (bdb2608) to head (b12a463).
Report is 509 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19465      +/-   ##
==========================================
+ Coverage   52.86%   55.87%   +3.01%     
==========================================
  Files         315      315              
  Lines       43645    43654       +9     
==========================================
+ Hits        23073    24392    +1319     
+ Misses      18025    16708    -1317     
- Partials     2547     2554       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
collect e2e coverage from app-controller
122280f 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner August 10, 2024 17:43
@crenshaw-dev
Copy link
Member

Good indication that the change allowed coverage data to be produced:

image

leehosu and others added 5 commits August 11, 2024 06:40
@leehosu
Remove select {}
02410ad 
Signed-off-by: leehosu <hosu4549@gmail.com>
@leehosu
Merge branch 'feat/config-graceful-shutdown-controller' of https://gi…
97a6da7 
…thub.com/leehosu/argo-cd into feat/config-graceful-shutdown-controller
@leehosu
Add ctx.done() about application-controller
d46cf9e 
Signed-off-by: leehosu <hosu4549@gmail.com>
@crenshaw-dev
simplify
85f2c45 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@leehosu
Merge pull request #1 from crenshaw-dev/feat/config-graceful-shutdown…
b12a463 
…-controller-simplify

simplify
crenshaw-dev
crenshaw-dev approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @leehosu!

@crenshaw-dev crenshaw-dev merged commit dad6fa2 into argoproj:master Aug 11, 2024
28 of 29 checks passed
ilia-medvedev-codefresh pushed a commit to ilia-medvedev-codefresh/argo-cd that referenced this pull request Aug 13, 2024
@leehosu @crenshaw-dev @ilia-medvedev-codefresh
feat: Implement graceful shutdown in application-controller (argoproj…
36cd674 
…#19465)

* Implement graceful shutdown in argocd-application-controller

Signed-off-by: leehosu <hosu4549@gmail.com>

* Implement code to pass waitGroup to Run function

Signed-off-by: leehosu <hosu4549@gmail.com>

* Add retuen nil

Signed-off-by: leehosu <hosu4549@gmail.com>

* Add log for lean shutdown

Signed-off-by: leehosu <hosu4549@gmail.com>

* collect e2e coverage from app-controller

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* Remove select {}

Signed-off-by: leehosu <hosu4549@gmail.com>

* Add ctx.done() about application-controller

Signed-off-by: leehosu <hosu4549@gmail.com>

* simplify

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Ilia Medvedev <ilia.medvedev@codefresh.io>
reggie-k pushed a commit to reggie-k/argo-cd that referenced this pull request Aug 14, 2024
@leehosu @crenshaw-dev @reggie-k
feat: Implement graceful shutdown in application-controller (argoproj…
55b936a 
…#19465)

* Implement graceful shutdown in argocd-application-controller

Signed-off-by: leehosu <hosu4549@gmail.com>

* Implement code to pass waitGroup to Run function

Signed-off-by: leehosu <hosu4549@gmail.com>

* Add retuen nil

Signed-off-by: leehosu <hosu4549@gmail.com>

* Add log for lean shutdown

Signed-off-by: leehosu <hosu4549@gmail.com>

* collect e2e coverage from app-controller

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* Remove select {}

Signed-off-by: leehosu <hosu4549@gmail.com>

* Add ctx.done() about application-controller

Signed-off-by: leehosu <hosu4549@gmail.com>

* simplify

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@leehosu leehosu mentioned this pull request Oct 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leehosu @crenshaw-dev