Implement graceful shutdown in all Argo CD components #18642
Labels
bug
Something isn't working
component:api
API bugs and enhancements
component:application-sets
Bulk application management related
component:notifications
Related to notifications subsystem
component:repo-server
type:enhancement
version:2.14
Latest confirmed affected version is 2.14
Comments
13 tasks
D0ri123
added a commit
to D0ri123/argo-cd
that referenced
this issue
Aug 4, 2024
14 tasks
alexmt
added
component:api
|
I'll fix the argocd-application-controller, I'll upload the PR soon. |
14 tasks
|
@crenshaw-dev Hi, crenshaw! |
andrii-korotkov-verkada
added
the
version:2.14
|
Only one left, or was it fixed too? |
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
14 tasks
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Nov 28, 2024
Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Dec 3, 2024
Helps with argoproj#18642 Needed for consistency and for future testing in another PR. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
14 tasks
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this issue
Dec 4, 2024
…rgoproj#21045) Helps with argoproj#18642 Needed for consistency and for future testing in another PR. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this issue
Dec 4, 2024
…20981) * fix: Graceful shutdown for the API server (argoproj#18642) Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this issue
Dec 9, 2024
* fix: Graceful shutdown for the API server (#18642) Closes #18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this issue
Dec 9, 2024
* fix: Graceful shutdown for the API server (#18642) Closes #18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
to crenshaw-dev/argo-cd
that referenced
this issue
Dec 17, 2024
…rgoproj#20981)" This reverts commit 730363f. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
pasha-codefresh
added a commit
to pasha-codefresh/argo-cd
that referenced
this issue
Dec 17, 2024
…rgoproj#20981)" This reverts commit 730363f.
pasha-codefresh
added a commit
that referenced
this issue
Dec 17, 2024
pasha-codefresh
pushed a commit
that referenced
this issue
Dec 17, 2024
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this issue
Dec 17, 2024
…20981) * fix: Graceful shutdown for the API server (argoproj#18642) Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
14 tasks
leoluz
added a commit
that referenced
this issue
Dec 17, 2024
* fix: Graceful shutdown for the API server (#18642) (#20981) * fix: Graceful shutdown for the API server (#18642) Closes #18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Use a custom signal for graceful restart Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Re-run tests Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this issue
Dec 17, 2024
* fix: Graceful shutdown for the API server (#18642) (#20981) * fix: Graceful shutdown for the API server (#18642) Closes #18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Use a custom signal for graceful restart Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Re-run tests Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
pasha-codefresh
pushed a commit
that referenced
this issue
Dec 18, 2024
* fix: Graceful shutdown for the API server (#18642) (#20981) * fix: Graceful shutdown for the API server (#18642) Closes #18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. * Init server only once, but keep re-initializing listeners * Check error for SetParamInSettingConfigMap as needed after fresh master * Prevent a data race * Remove unused variable, don't pass lock when not necessary * Try overriding URL instead of additional URLs * Use a more specific url --------- * Use a custom signal for graceful restart * Re-run tests --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Andrii Korotkov <137232734+andrii-korotkov-verkada@users.noreply.github.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Procfile sets GOCOVDIR for five Argo CD components. But only one (applicationset-controller) shuts down gracefully enough for code coverage data to be produced. In other words, go writes a covmeta file, but not a covcounters file (the file that actually contains coverage info). So today we get partial code coverage info for e2e tests.
The task is to do two things for the remaining four components: 1) implement graceful shutdown and 2) add the component's gocov directory to the e2e reporting CI.
Exactly what "graceful shutdown means" may vary by component. Concretely, I think it means we need to listen to shutdown signals and end all running goroutines. But the "graceful" part depends on what's running.
The text was updated successfully, but these errors were encountered: