Skip to content

Commit

Permalink
chore: Add support for AdditionalURLs field in server settings query (#…
Browse files Browse the repository at this point in the history
…21045)

Helps with #18642

Needed for consistency and for future testing in another PR.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
  • Loading branch information
andrii-korotkov-verkada authored Dec 3, 2024
1 parent 52dbe51 commit 9757866
Show file tree
Hide file tree
Showing 4 changed files with 146 additions and 80 deletions.
6 changes: 6 additions & 0 deletions assets/swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

218 changes: 138 additions & 80 deletions pkg/apiclient/settings/settings.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions server/settings/settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ func (s *Server) Get(ctx context.Context, q *settingspkg.SettingsQuery) (*settin

set := settingspkg.Settings{
URL: argoCDSettings.URL,
AdditionalURLs: argoCDSettings.AdditionalURLs,
AppLabelKey: appInstanceLabelKey,
ResourceOverrides: overrides,
StatusBadgeEnabled: argoCDSettings.StatusBadgeEnabled,
Expand Down
1 change: 1 addition & 0 deletions server/settings/settings.proto
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ message Settings {
bool appsInAnyNamespaceEnabled = 24;
bool impersonationEnabled = 25;
string installationID = 26;
repeated string additionalUrls = 27 [(gogoproto.customname) = "AdditionalURLs"];
}

message GoogleAnalyticsConfig {
Expand Down

0 comments on commit 9757866

Please sign in to comment.