Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for AdditionalURLs field in server settings query #21045

Conversation

andrii-korotkov-verkada
Copy link
Contributor

Helps with #18642

Needed for consistency and for future testing in another PR.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Helps with argoproj#18642

Needed for consistency and for future testing in another PR.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
@andrii-korotkov-verkada andrii-korotkov-verkada requested a review from a team as a code owner December 3, 2024 15:41
Copy link

bunnyshell bot commented Dec 3, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz enabled auto-merge (squash) December 3, 2024 15:42
@leoluz leoluz merged commit 9757866 into argoproj:master Dec 3, 2024
26 checks passed
@andrii-korotkov-verkada andrii-korotkov-verkada deleted the 18642-add-additional-urls-field branch December 3, 2024 16:20
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (master@0d7f1f7). Learn more about missing BASE report.
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
server/settings/settings.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #21045   +/-   ##
=========================================
  Coverage          ?   55.06%           
=========================================
  Files             ?      324           
  Lines             ?    55483           
  Branches          ?        0           
=========================================
  Hits              ?    30554           
  Misses            ?    22309           
  Partials          ?     2620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
…rgoproj#21045)

Helps with argoproj#18642

Needed for consistency and for future testing in another PR.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants