Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add health status and message in sync status list #19875

Merged
merged 2 commits into from
Sep 12, 2024
Merged

feat(ui): add health status and message in sync status list #19875

merged 2 commits into from
Sep 12, 2024

Conversation

linghaoSu
Copy link
Member

Fixes #18953

2024-09-11.10.05.25.mov

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@linghaoSu
feat(ui): add health status and message in sync status list
cba04e2 
Signed-off-by: linghaoSu <linghao.su@daocloud.io>
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 11, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 11, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@linghaoSu linghaoSu marked this pull request as ready for review September 11, 2024 02:07
@linghaoSu linghaoSu requested a review from a team as a code owner September 11, 2024 02:07
@alexmt alexmt merged commit 20e7f8e into argoproj:master Sep 12, 2024
22 of 23 checks passed
@linghaoSu linghaoSu mentioned this pull request Sep 22, 2024
Closed
6 tasks
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@linghaoSu @alexmt @adriananeci
feat(ui): add health status and message in sync status list (argoproj…
54dbfa2 
…#19875)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitishfy nitishfy nitishfy approved these changes

@wanghong230 wanghong230 wanghong230 approved these changes

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show health of resources on the Sync details page
4 participants
@linghaoSu @alexmt @wanghong230 @nitishfy