Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo-server): unify semver resolution in new versions subpackage #20216

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

PaulSonOfLars
Copy link
Contributor

Unify semver resolution across helm/OCI/git into a single package, to ensure we don't end up with mismatched logic for different services

Follow up to #20096, as requested here. cc @blakepettersson

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@PaulSonOfLars PaulSonOfLars requested a review from a team as a code owner October 3, 2024 17:17
Copy link

bunnyshell bot commented Oct 3, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Oct 3, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far! Just a few minor comments

util/helm/client.go Outdated Show resolved Hide resolved
util/versions/version.go Show resolved Hide resolved
@blakepettersson
Copy link
Member

I think you also need to run make mockgen

@blakepettersson blakepettersson changed the title fix: Unify semver resolution in new versions subpackage fix: unify semver resolution in new versions subpackage Oct 4, 2024
@PaulSonOfLars PaulSonOfLars force-pushed the paul/unify-semver-resolution branch from a68229a to bbe0191 Compare October 4, 2024 18:32
@blakepettersson blakepettersson changed the title fix: unify semver resolution in new versions subpackage refactor(repo-server): unify semver resolution in new versions subpackage Oct 4, 2024
@blakepettersson blakepettersson changed the title refactor(repo-server): unify semver resolution in new versions subpackage chore(repo-server): unify semver resolution in new versions subpackage Oct 4, 2024
@PaulSonOfLars PaulSonOfLars force-pushed the paul/unify-semver-resolution branch from 3e9d145 to 7e0fbd0 Compare October 8, 2024 11:04
util/helm/index.go Outdated Show resolved Hide resolved
util/helm/index_test.go Outdated Show resolved Hide resolved
reposerver/repository/repository.go Outdated Show resolved Hide resolved
reposerver/repository/repository_test.go Outdated Show resolved Hide resolved
util/helm/client_test.go Outdated Show resolved Hide resolved
util/helm/client_test.go Outdated Show resolved Hide resolved
util/helm/index.go Outdated Show resolved Hide resolved
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
@PaulSonOfLars PaulSonOfLars force-pushed the paul/unify-semver-resolution branch from 7e0fbd0 to 8884bb8 Compare October 18, 2024 17:40
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
@PaulSonOfLars PaulSonOfLars force-pushed the paul/unify-semver-resolution branch from 8884bb8 to efb245e Compare October 18, 2024 19:02
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
@PaulSonOfLars
Copy link
Contributor Author

@blakepettersson thanks for the review!
I've reverted things back to entries and added in a private struct for the tags methods. Also fixed some tests which were failing due to new error messages. Let me know if you'd like me to poke at anything else!

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 77.92208% with 17 lines in your changes missing coverage. Please review.

Project coverage is 55.21%. Comparing base (ec499bb) to head (3ca3a59).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
util/helm/index.go 0.00% 6 Missing ⚠️
util/versions/tags.go 82.35% 4 Missing and 2 partials ⚠️
reposerver/repository/repository.go 77.77% 3 Missing and 1 partial ⚠️
util/helm/client.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20216      +/-   ##
==========================================
+ Coverage   55.07%   55.21%   +0.13%     
==========================================
  Files         322      324       +2     
  Lines       54927    55042     +115     
==========================================
+ Hits        30253    30389     +136     
+ Misses      22068    22042      -26     
- Partials     2606     2611       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, otherwise this looks great. Thanks!

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@Spazzy757
Copy link

Hey!

Is there any update on this? We have a pending bug that we would like fixed, but we are waiting on this PR 😄

#20862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for final review
Development

Successfully merging this pull request may close these issues.

5 participants