-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo-server): unify semver resolution in new versions subpackage #20216
base: master
Are you sure you want to change the base?
chore(repo-server): unify semver resolution in new versions subpackage #20216
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far! Just a few minor comments
I think you also need to run |
a68229a
to
bbe0191
Compare
3e9d145
to
7e0fbd0
Compare
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
7e0fbd0
to
8884bb8
Compare
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
8884bb8
to
efb245e
Compare
@blakepettersson thanks for the review! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20216 +/- ##
==========================================
+ Coverage 55.07% 55.21% +0.13%
==========================================
Files 322 324 +2
Lines 54927 55042 +115
==========================================
+ Hits 30253 30389 +136
+ Misses 22068 22042 -26
- Partials 2606 2611 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing, otherwise this looks great. Thanks!
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Hey! Is there any update on this? We have a pending bug that we would like fixed, but we are waiting on this PR 😄 |
Unify semver resolution across helm/OCI/git into a single package, to ensure we don't end up with mismatched logic for different services
Follow up to #20096, as requested here. cc @blakepettersson
Checklist: