feat: allow for specifying pre-release in regex

[Spazzy757]

This PR allows for checking for pre-release specific tags

previously in the case of having a pre-release (i.e v1.0.*-rc) the git check would ignore the pre-release versions and just do the latest tag (i.e v1.0.1) which could be a different release entirely.

NOTE: My assumption is that this is only valid with wildcards as I dont think something like < v1.2.*-rc would be a valid constraint, but if this is incorrect please let me know

I am not entirely sure if this is considered a bug fix or a feature

Related Issue: #18899

Related Discussion: #20595

would be great to have this patched in v2.12

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.06%. Comparing base (3b81d3c) to head (0c85079).
Report is 22 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20862      +/-   ##
==========================================
+ Coverage   55.02%   55.06%   +0.03%     
==========================================
  Files         324      324              
  Lines       55413    55423      +10     
==========================================
+ Hits        30492    30517      +25     
+ Misses      22306    22295      -11     
+ Partials     2615     2611       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Spazzy757]

Hi, is there anything further thats needed for this change?

[andrii-korotkov-verkada]

Would you be able to join the contributors meeting and discuss this?

[blakepettersson]

I'd like to see #20216 merged before considering this - since otherwise the way semver is handled in Git would differ from how it is done in Helm (and in the future, OCI)

To be fair, I'm not sure how Helm handles pre-release tags, so it could very well be that this may need to differ.

[Spazzy757]

Would you be able to join the contributors meeting and discuss this?

Yes sure, is it at: Thursday at 8:15AM Pacific Time?

[Spazzy757]

I'd like to see #20216 merged before considering this - since otherwise the way semver is handled in Git would differ from how it is done in Helm (and in the future, OCI)

To be fair, I'm not sure how Helm handles pre-release tags, so it could very well be that this may need to differ.

@blakepettersson I'd be happy to fix this there once that is merged, is there a time frame on when that refactor is being merged?

[blakepettersson]

Yes sure, is it at: Thursday at 8:15AM Pacific Time?

It is, but due to Thanksgiving this upcoming one is cancelled, so it'll have to be the contributors' meeting next week. Alternatively feel free to ask for other opinions on the #argo-cd-contributors channel on the CNCF Slack.

@blakepettersson I'd be happy to fix this there once that is merged, is there a time frame on when that refactor is being merged?

No idea, but IMO this should be good to go right now. I'll need to poke a maintainer to merge that PR.

[Spazzy757]

Yes sure, is it at: Thursday at 8:15AM Pacific Time?

It is, but due to Thanksgiving this upcoming one is cancelled, so it'll have to be the contributors' meeting next week. Alternatively feel free to ask for other opinions on the #argo-cd-contributors channel on the CNCF Slack.

@blakepettersson I'd be happy to fix this there once that is merged, is there a time frame on when that refactor is being merged?

No idea, but IMO this should be good to go right now. I'll need to poke a maintainer to merge that PR.