Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Keep autogenerated message in upstream.yaml for HA manifests #3367

Merged

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Apr 5, 2020

Restore the "This file is autogenerated..." message in upstream.yaml of the HA manifest generation, which was removed by accident in PR #3356

Checklist:

  • (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

@jannfis jannfis requested a review from alexmt April 5, 2020 15:09
@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #3367 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3367      +/-   ##
==========================================
+ Coverage   40.43%   40.50%   +0.06%     
==========================================
  Files         175      175              
  Lines       19059    19085      +26     
  Branches      237      237              
==========================================
+ Hits         7707     7730      +23     
- Misses      10418    10419       +1     
- Partials      934      936       +2     
Impacted Files Coverage Δ
server/account/account.go 70.31% <0.00%> (+4.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9072d8...c167e25. Read the comment docs.

@alexmt alexmt merged commit 6eb4f41 into argoproj:master Apr 6, 2020
alexmt pushed a commit that referenced this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants