fix: Increase HAProxy check interval to prevent intermittent failures #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3356 +/- ##
=========================================
- Coverage 40.54% 40.5% -0.04%
=========================================
Files 175 175
Lines 19019 19079 +60
Branches 237 237
=========================================
+ Hits 7711 7728 +17
- Misses 10377 10415 +38
- Partials 931 936 +5
Continue to review full report at Codecov.
|
alexmt
approved these changes
Apr 3, 2020
| >> ./chart/upstream.yaml | ||
| >> ./chart/upstream_orig.yaml | ||
|
|
||
| sed -e 's/check inter 1s/check inter 3s/' ./chart/upstream_orig.yaml > ./chart/upstream.yaml && rm ./chart/upstream_orig.yaml |
There was a problem hiding this comment.
👍 that looks good enough to me
This was referenced Apr 5, 2020
alexmt
pushed a commit
that referenced
this pull request
Apr 6, 2020
…#3356) * Increase HAProxy check interval to prevent intermittent failures/state flapping * Restore original namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases HAProxy check interval from 1s to 3s, see slack thread https://argoproj.slack.com/archives/CASHNF6MS/p1585935567397100
Checklist:
Closes #3358