Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed unused env section in redis-ha manifests. #3366

Closed

Conversation

yutachaos
Copy link
Contributor

@yutachaos yutachaos commented Apr 5, 2020

Checklist:

  • (b) this is a bug fix
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Description

  • This env part is not used in the manifest, and it becomes null when kusttomize build and an error occurs. See issue for details.

Related issue

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2020

CLA assistant check
All committers have signed the CLA.

@yutachaos yutachaos changed the title Deleted unsed env redis-ha manifests Removed unused env section in redis-ha manifests. Apr 5, 2020
@yutachaos yutachaos force-pushed the feature/fixed_redis_manifest branch from 193c9e8 to 40d0866 Compare April 5, 2020 14:57
@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #3366 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3366      +/-   ##
==========================================
+ Coverage   40.43%   40.61%   +0.17%     
==========================================
  Files         175      127      -48     
  Lines       19059    17687    -1372     
  Branches      237        0     -237     
==========================================
- Hits         7707     7184     -523     
+ Misses      10418     9570     -848     
+ Partials      934      933       -1
Impacted Files Coverage Δ
ui/src/app/applications/components/resources.ts
ui/src/app/shared/components/index.ts
ui/src/app/shared/components/urls.ts
ui/src/app/shared/services/applications-service.ts
ui/src/app/shared/services/requests.ts
.../app/shared/components/yaml-editor/yaml-editor.tsx
...hared/components/editable-panel/editable-panel.tsx
ui/src/app/shared/services/repocreds-service.ts
ui/src/app/shared/services/accounts-service.ts
ui/src/app/shared/components/colors.ts
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9072d8...40d0866. Read the comment docs.

@yutachaos yutachaos changed the title Removed unused env section in redis-ha manifests. fix: Removed unused env section in redis-ha manifests. Apr 5, 2020
@jannfis
Copy link
Member

jannfis commented Apr 5, 2020

Hi @yutachaos, thanks for your PR! Unfortunately, upstream.yaml is generated during codegen, so your fix will be overwritten. The accompanying note in the file was removed by accident in PR #3356.I have submitted a fix to bring this message back in.

@yutachaos
Copy link
Contributor Author

I understood this manifest generated during codegen.
It is a root problem helm chart.
I published a PR on Helm chart
helm/charts#21777
Close this PR.

@yutachaos yutachaos closed this Apr 5, 2020
@yutachaos yutachaos deleted the feature/fixed_redis_manifest branch April 6, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants