Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update 4.5.3 redis-ha helm manifest #3370

Merged

Conversation

yutachaos
Copy link
Contributor

@yutachaos yutachaos commented Apr 6, 2020

Checklist:

  • (b) this is a bug fix
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Description

Related issue

@yutachaos yutachaos changed the title Update 4.5.3 redis-ha helm manifest [WIP] Update 4.5.3 redis-ha helm manifest Apr 6, 2020
@yutachaos yutachaos changed the title [WIP] Update 4.5.3 redis-ha helm manifest fix: Update 4.5.3 redis-ha helm manifest Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #3370 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3370      +/-   ##
==========================================
+ Coverage   40.51%   40.63%   +0.11%     
==========================================
  Files         175      127      -48     
  Lines       19090    17692    -1398     
  Branches      237        0     -237     
==========================================
- Hits         7735     7189     -546     
+ Misses      10419     9570     -849     
+ Partials      936      933       -3
Impacted Files Coverage Δ
ui/src/app/applications/components/resources.ts
ui/src/app/shared/components/index.ts
ui/src/app/shared/components/urls.ts
ui/src/app/shared/services/applications-service.ts
ui/src/app/shared/services/requests.ts
.../app/shared/components/yaml-editor/yaml-editor.tsx
...hared/components/editable-panel/editable-panel.tsx
ui/src/app/shared/services/repocreds-service.ts
ui/src/app/shared/services/accounts-service.ts
ui/src/app/shared/components/colors.ts
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdd782...900d31a. Read the comment docs.

@yutachaos yutachaos force-pushed the feature/update_redis_ha_manifest branch 5 times, most recently from e6a283c to 0c14e1d Compare April 6, 2020 09:55
Signed-off-by: yutachaos <18604471+yutachaos@users.noreply.github.com>
@yutachaos yutachaos force-pushed the feature/update_redis_ha_manifest branch from 0c14e1d to 778446e Compare April 6, 2020 10:00
@yutachaos yutachaos closed this Apr 6, 2020
@yutachaos yutachaos force-pushed the feature/update_redis_ha_manifest branch from 778446e to 9fdd782 Compare April 6, 2020 12:25
@yutachaos yutachaos reopened this Apr 6, 2020
@yutachaos yutachaos force-pushed the feature/update_redis_ha_manifest branch 4 times, most recently from 030e0b9 to c5563fb Compare April 6, 2020 13:17
@yutachaos yutachaos force-pushed the feature/update_redis_ha_manifest branch 2 times, most recently from 6651bc1 to 778446e Compare April 6, 2020 13:30
@jannfis
Copy link
Member

jannfis commented Apr 6, 2020

Hi @yutachaos, thanks for your ongoing effort!

I think to pass the codegen step on CI you should do the following instead of applying the patches codegen step produces:

  • perform the changes for the Chart update locally
  • run make manifests
  • compare changes against your Git repo and commit them after review
  • push changes to your GH branch

This should resolve the diffs that the CI's codegen step is producing.

@yutachaos
Copy link
Contributor Author

yutachaos commented Apr 6, 2020

@jannfis
Thank you!!
Solve it.

@jessesuen jessesuen merged commit 0eec2fe into argoproj:master Apr 6, 2020
@yutachaos yutachaos deleted the feature/update_redis_ha_manifest branch April 7, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants