-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply scopes from argocd-rbac-cm to project jwt group searches #3508
fix: apply scopes from argocd-rbac-cm to project jwt group searches #3508
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3508 +/- ##
==========================================
+ Coverage 40.99% 41.28% +0.28%
==========================================
Files 114 114
Lines 16403 16447 +44
==========================================
+ Hits 6725 6790 +65
+ Misses 8797 8776 -21
Partials 881 881
Continue to review full report at Codecov.
|
I definitely signed the CLA and updated my git email for the commit, so I'm not sure what to do for it to recognize it was signed. |
Hi @Erog38, thanks a lot for your contribution! The changes look good from a technical perspective to me, I just have a small request: Is there an existing issue describing the problem this PR is solving? If yes, can you please link it. If not, can you please elaborate a little on the use case of this PR? Thank you! |
@jannfis For a little more perspective, we use amazon cognito which does not allow using a |
@jannfis Is there any more information I can help provide for you? |
@Erog38 Sorry for the delay, I will start reviewing this PR now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission and sorry for the delay in review.
I have reviewed your change and manually tested for regression, it looks good so far to me. I have some minor comments (see below), I feel you should run make lint
over your code, maybe I have missed some white space issue ;)
@jessesuen Maybe you want to take a look at this change because it's OAuth related, and I think you're the one knowing it inside-out. |
I adjusted the whitespace issues , please let me know if I can adjust anything else, I want to get this out to our integration environment soon so we can start going production ready 😃 |
41f8dbd
to
a116d24
Compare
Hi @Erog38, as the This change was very intrusive, and probably requires manual rework of most pending PRs in the queue. Sorry for that, but we couldn't wait any longer with that change. |
@jannfis no worries, I know how these things are. I've brought the branch up to date. it looks like the workflow is failing on an unauthorized error from Sonarcloud. Do you know anything about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for going the extra mile!
We're still unsure why this step works for some users while it won't work for others. I think it's some bug (or feature?) with CircleCI. |
Sorry @jannfis but is there another step I can get here for this to be merged as well? |
Hey @Erog38, all is fine from my side. I was just thinking that @jessesuen might want to take a look too before merging this. |
Checklist: