Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add EA to USERS.md #3704

Merged
merged 2 commits into from
Jun 4, 2020
Merged

docs: Add EA to USERS.md #3704

merged 2 commits into from
Jun 4, 2020

Conversation

ragarcia26
Copy link
Contributor

@ragarcia26 ragarcia26 commented Jun 3, 2020

With 2 accepted PR's as well as active internal use, we'd like to put our name on here.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Based off of:
#3508
and
#3667
and
argoproj/argo-helm#350
and our actual use of the product :)

With 2 accepted PR's as well as active internal use, we'd like to put our name on here.
@CLAassistant
Copy link

CLAassistant commented Jun 3, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #3704 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3704   +/-   ##
=======================================
  Coverage   41.50%   41.50%           
=======================================
  Files         115      115           
  Lines       16540    16540           
=======================================
  Hits         6865     6865           
  Misses       8785     8785           
  Partials      890      890           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e775b8f...5abd4dd. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@alexmt alexmt merged commit 4bf6e88 into argoproj:master Jun 4, 2020
@dirtycajunrice
Copy link
Contributor

@alexmt Just for complete explicitness, we have approval from legal for our name and link here on this page, but do not have approval for our logo to exist anywhere (e.g. on a webpage). Thank you for understanding in advance. Just wanted to make sure it was stated somewhere in-case more than the above is added!

@alexmt
Copy link
Collaborator

alexmt commented Jun 4, 2020

Thank you for heads up @dirtycajunrice . No problem at all.

Logos are added automatically to this web site: https://argoproj.github.io/ . The job that generates the page has no run yet. Updating script to make sure EA logo is not added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants