Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo on spec.loadBalancerSourceRanges for argocd-server/service.yaml #350

Merged

Conversation

johnpekcan
Copy link
Contributor

@johnpekcan johnpekcan commented May 15, 2020

Hey team, while trying to set some elb security groups, I ran into an error:

 Comparing release=argocd, chart=argo/argo-cd
 in ./helmfile.yaml: failed processing release argocd: helm exited with status 1:
   Error: Failed to render chart: exit status 1: Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Service.spec): unknown field "loadBalancerSourceranges" in io.k8s.api.core.v1.ServiceSpec
   
   Error: plugin "diff" exited with error
Running after_script
00:01
Uploading artifacts for failed job
 ERROR: Job failed: exit code 1

Upon looking at the chart, it appears there is a typo on the key loadBalancerSourceRanges -- per kube docs
Please let me know if I can provide any additional information.

Checklist:

  • I have update the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • I have followed the testing instructions in the contributing guide.
  • I have signed the CLA and the build is green.
  • I will test my changes again once merged to master and published.

Changes are automatically published when merged to master. They are not published on branches.

@CLAassistant
Copy link

CLAassistant commented May 15, 2020

CLA assistant check
All committers have signed the CLA.

@johnpekcan johnpekcan changed the title fixing typo on spec.loadBalancerSourceRanges for argocd-server/service.yaml fix: typo on spec.loadBalancerSourceRanges for argocd-server/service.yaml May 15, 2020
Signed-off-by: John Pekcan <johnpekcan@gmail.com>
@johnpekcan johnpekcan force-pushed the loadbalancer-source-range-typo branch from c613fa3 to 436b989 Compare May 15, 2020 02:44
Copy link
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch

@spencergilbert spencergilbert merged commit 74c54ac into argoproj:master May 18, 2020
@johnpekcan johnpekcan deleted the loadbalancer-source-range-typo branch May 18, 2020 15:58
muwon pushed a commit to muwon/argo-helm that referenced this pull request Oct 10, 2020
Signed-off-by: John Pekcan <johnpekcan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants