refactor: upgrade redis-ha to 4.12.14 & cleanup generate.sh

[aniekgul]

Following this upstream redis-ha PR all the required configurations set using sed in the generate script can now be set via the chart's values.

Signed-off-by: Aniek Gul aniekgul@hotmail.com

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Merging #6021 (d09aaea) into master (61080b3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6021   +/-   ##
=======================================
  Coverage   40.93%   40.93%           
=======================================
  Files         147      147           
  Lines       19661    19661           
=======================================
  Hits         8049     8049           
  Misses      10508    10508           
  Partials     1104     1104           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61080b3...d09aaea. Read the comment docs.

[jannfis]

Thank you @aniekgul, I think this is a great change. Removing some dirty hacks from our manifest generation sounds like a good idea.

Can you please resolve the merge conflict?

[aniekgul]

@jannfis fixed the conflict. Unfortunately the new sentinel bind conf will have to be stay as a hack but I can take a look at adding support for it in the upstream chart later.

[jannfis]

Thank you @aniekgul! Much appreciated!

LGTM.