Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade redis-ha to 4.12.15, use bind value #6205

Merged
merged 1 commit into from
May 11, 2021

Conversation

aniekgul
Copy link
Contributor

@aniekgul aniekgul commented May 10, 2021

Signed-off-by: Aniek Gul aniekgul@hotmail.com

Follow up to #6021

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Aniek Gul <aniekgul@hotmail.com>
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #6205 (b8c33f0) into master (4761656) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6205   +/-   ##
=======================================
  Coverage   41.19%   41.19%           
=======================================
  Files         147      147           
  Lines       19857    19857           
=======================================
  Hits         8181     8181           
  Misses      10556    10556           
  Partials     1120     1120           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4761656...b8c33f0. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @aniekgul !

@jannfis jannfis merged commit ac2491d into argoproj:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants