-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update link to the new CNCF Slack channel #6044
Conversation
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6044 +/- ##
=======================================
Coverage 40.96% 40.96%
=======================================
Files 147 147
Lines 19682 19682
=======================================
Hits 8062 8062
Misses 10514 10514
Partials 1106 1106
Continue to review full report at Codecov.
|
@@ -1,5 +1,5 @@ | |||
[![Integration tests](https://github.com/argoproj/argo-cd/workflows/Integration%20tests/badge.svg?branch=master)](https://github.com/argoproj/argo-cd/actions?query=workflow%3A%22Integration+tests%22) | |||
[![slack](https://img.shields.io/badge/slack-argoproj-brightgreen.svg?logo=slack)](https://argoproj.github.io/community/join-slack) | |||
[![slack](https://img.shields.io/badge/slack-argo_cd-brightgreen.svg?logo=slack)](https://cloud-native.slack.com/archives/C01TSERG0KZ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that actually the correct URL? If I click on that, I get a sign on page, but no possibility to create an account 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've posted https://argoproj.github.io/community/join-slack
in other places.
Can we update https://github.com/argoproj/argo-site/blob/master/static/community/join-slack.html instead and keep using https://argoproj.github.io/community/join-slack
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jannfis Good catch...It's the correct URL but looks like you do need an account in that workspace first before you can join the channels.
@alexmt Perhaps we can update that join-slack html to be a plain HTML instead of a redirect? The content would include instruction to join https://slack.cncf.io/ workspace and then provide links to different channels on that page. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed this with @alexmt who's going to reuse the existing link with instructions to join the CNCF workspace and channels. Closing this for now.
Signed-off-by: terrytangyuan terrytangyuan@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: