Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Revert "docs: Update link to the new CNCF Slack channel (#5681)" #5684

Merged
merged 1 commit into from
Apr 16, 2021
Merged

docs: Revert "docs: Update link to the new CNCF Slack channel (#5681)" #5684

merged 1 commit into from
Apr 16, 2021

Conversation

terrytangyuan
Copy link
Member

I discussed with @alexmt and he's going to reuse the existing link with instructions to join the CNCF workspace and channels. See argoproj/argo-cd#6044 (comment) for more context. Reverting previous change.

This reverts commit eab122b.

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Checklist:

@terrytangyuan terrytangyuan changed the title Revert "docs: Update link to the new CNCF Slack channel (#5681)" docs: Revert "docs: Update link to the new CNCF Slack channel (#5681)" Apr 15, 2021
@terrytangyuan terrytangyuan reopened this Apr 15, 2021
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #5684 (0e3f35e) into master (a018523) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 0e3f35e differs from pull request most recent head b1bbf17. Consider uploading reports for the commit b1bbf17 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5684      +/-   ##
==========================================
+ Coverage   47.12%   47.15%   +0.02%     
==========================================
  Files         242      242              
  Lines       15136    15136              
==========================================
+ Hits         7133     7137       +4     
+ Misses       7095     7093       -2     
+ Partials      908      906       -2     
Impacted Files Coverage Δ
cmd/argo/commands/get.go 56.95% <0.00%> (+0.64%) ⬆️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a018523...b1bbf17. Read the comment docs.

@alexec alexec merged commit 3c8f561 into argoproj:master Apr 16, 2021
@terrytangyuan terrytangyuan deleted the revert-link branch April 16, 2021 16:02
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants