Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update link to the new CNCF Slack channel #5681

Merged
merged 1 commit into from
Apr 15, 2021
Merged

docs: Update link to the new CNCF Slack channel #5681

merged 1 commit into from
Apr 15, 2021

Conversation

terrytangyuan
Copy link
Member

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Checklist:

@terrytangyuan
docs: Update link to the new CNCF Slack channel
84a8ffd 
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #5681 (adc4194) into master (bf5d7bf) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head adc4194 differs from pull request most recent head 84a8ffd. Consider uploading reports for the commit 84a8ffd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5681      +/-   ##
==========================================
+ Coverage   47.07%   47.11%   +0.03%     
==========================================
  Files         242      242              
  Lines       15135    15135              
==========================================
+ Hits         7125     7131       +6     
+ Misses       7106     7097       -9     
- Partials      904      907       +3
Impacted Files Coverage Δ
cmd/argo/commands/get.go 55.66% <0.00%> (-1.30%) ⬇️
server/workflow/workflow_server.go 42.73% <0.00%> (+2.27%) ⬆️
workflow/metrics/server.go 16.66% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5d7bf...84a8ffd. Read the comment docs.

alexec
alexec reviewed Apr 15, 2021
View reviewed changes
README.md
@@ -1,4 +1,4 @@
[![slack](https://img.shields.io/badge/slack-argoproj-brightgreen.svg?logo=slack)](https://argoproj.github.io/community/join-slack)
[![slack](https://img.shields.io/badge/slack-argo_workflows-brightgreen.svg?logo=slack)](https://cloud-native.slack.com/archives/C01QW9QSSSK)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexmt can we have a page on argoproj.io that captures analytics and then redirects please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great. Let me know once it's ready and I can update the link here.

@alexec
Copy link
Contributor

alexec commented Apr 15, 2021

This is more correct, I'm merging.

@alexec alexec merged commit eab122b into argoproj:master Apr 15, 2021
@terrytangyuan terrytangyuan deleted the slack-link branch April 15, 2021 16:23
alexec pushed a commit that referenced this pull request Apr 16, 2021
@terrytangyuan
docs: Revert "docs: Update link to the new CNCF Slack channel (#5681)" (
3c8f561 
#5684)

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@simster7 simster7 mentioned this pull request Apr 19, 2021
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrytangyuan @alexec