Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Undefined cluster in UI when app is referencing cluster by name #9493

Merged
merged 1 commit into from
May 24, 2022

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented May 23, 2022

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Closes #9492

PR fixes the API request issued by UI to load cluster by name.

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested review from jessesuen and rbreeze May 23, 2022 20:56
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #9493 (14ea177) into master (1b6275a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9493   +/-   ##
=======================================
  Coverage   45.71%   45.71%           
=======================================
  Files         221      221           
  Lines       26289    26289           
=======================================
  Hits        12019    12019           
  Misses      12610    12610           
  Partials     1660     1660           
Impacted Files Coverage Δ
util/settings/settings.go 48.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6275a...14ea177. Read the comment docs.

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexmt alexmt merged commit 15adda9 into argoproj:master May 24, 2022
@alexmt alexmt deleted the 9492-in-cluster-url branch May 24, 2022 05:03
alexmt added a commit that referenced this pull request May 24, 2022
…9493)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@crenshaw-dev crenshaw-dev added the cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch label Nov 17, 2022
crenshaw-dev pushed a commit that referenced this pull request Nov 17, 2022
…9493)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@crenshaw-dev
Copy link
Member

Cherry-picked onto release-2.3 for 2.3.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Undefined" cluster in UI when app is referencing cluster by name
3 participants