Update repository-credentials-secret.yaml #2892
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
force nindent for ssh support Signed-off-by: Johan Romero Aguirre <56489789+devromerops@users.noreply.github.com>
devromerops
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
yu-croco
reviewed
Aug 22, 2024
| @@ -16,6 +16,6 @@ metadata: | |||
| {{- end }} | |||
| data: | |||
| {{- range $key, $value := $repo_cred_value }} | |||
| {{ $key }}: {{ $value | toString | b64enc }} | |||
| {{ $key }}: {{ $value | toString | b64enc | nindent 4 }} | |||
There was a problem hiding this comment.
Can you please tell us why we need this?
As you can see the official doc, current definition looks ok, so I want to know the motivation.
apiVersion: v1
kind: Secret
metadata:
name: secret-sa-sample
annotations:
kubernetes.io/service-account.name: "sa-name"
type: kubernetes.io/service-account-token
data:
# You can include additional key value pairs as you do with Opaque Secrets
extra: YmFyCg==current
data:
githubAppEnterpriseBaseUrl: aHR0cHM6Ly9naGUuZXhhbXBsZS5jb20vYXBpL3Yz
githubAppID: MQ==
githubAppInstallationID: Mg==
githubAppPrivateKey: LS0tLS1CRUdJTiBPUEVOU1NIIFBSSVZBVEUgS0VZLS0tLS0KLi4uCi0tLS0tRU5EIE9QRU5TU0ggUFJJVkFURSBLRVktLS0tLQo=
url: aHR0cHM6Ly9naXRodWIuY29tL2FyZ29wcm9qthis PR
data:
githubAppEnterpriseBaseUrl:
aHR0cHM6Ly9naGUuZXhhbXBsZS5jb20vYXBpL3Yz
githubAppID:
MQ==
githubAppInstallationID:
Mg==
githubAppPrivateKey:
LS0tLS1CRUdJTiBPUEVOU1NIIFBSSVZBVEUgS0VZLS0tLS0KLi4uCi0tLS0tRU5EIE9QRU5TU0ggUFJJVkFURSBLRVktLS0tLQo=
url:
aHR0cHM6Ly9naXRodWIuY29tL2FyZ29wcm9q
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
force nindent for ssh support
Checklist: