Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repository-credentials-secret.yaml #2892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Update repository-credentials-secret.yaml #2892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/argo-cd/templates/argocd-configs/repository-credentials-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ metadata:
{{- end }}
data:
{{- range $key, $value := $repo_cred_value }}
{{ $key }}: {{ $value | toString | b64enc }}
{{ $key }}: {{ $value | toString | b64enc | nindent 4 }}
Copy link
Collaborator

@yu-croco yu-croco Aug 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please tell us why we need this?

As you can see the official doc, current definition looks ok, so I want to know the motivation.

apiVersion: v1
kind: Secret
metadata:
  name: secret-sa-sample
  annotations:
    kubernetes.io/service-account.name: "sa-name"
type: kubernetes.io/service-account-token
data:
  # You can include additional key value pairs as you do with Opaque Secrets
  extra: YmFyCg==

current

data:
  githubAppEnterpriseBaseUrl: aHR0cHM6Ly9naGUuZXhhbXBsZS5jb20vYXBpL3Yz
  githubAppID: MQ==
  githubAppInstallationID: Mg==
  githubAppPrivateKey: LS0tLS1CRUdJTiBPUEVOU1NIIFBSSVZBVEUgS0VZLS0tLS0KLi4uCi0tLS0tRU5EIE9QRU5TU0ggUFJJVkFURSBLRVktLS0tLQo=
  url: aHR0cHM6Ly9naXRodWIuY29tL2FyZ29wcm9q

this PR

data:
  githubAppEnterpriseBaseUrl: 
    aHR0cHM6Ly9naGUuZXhhbXBsZS5jb20vYXBpL3Yz
  githubAppID: 
    MQ==
  githubAppInstallationID: 
    Mg==
  githubAppPrivateKey: 
    LS0tLS1CRUdJTiBPUEVOU1NIIFBSSVZBVEUgS0VZLS0tLS0KLi4uCi0tLS0tRU5EIE9QRU5TU0ggUFJJVkFURSBLRVktLS0tLQo=
  url: 
    aHR0cHM6Ly9naXRodWIuY29tL2FyZ29wcm9q

{{- end }}
{{- end }}
Loading