-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request timed out in errors.isTransientNetworkErr #4144
Comments
This is a great idea. I think you need to add this to |
@alexec yes that's seems the right place to add, sure I will provide a PR. |
Good point. You're thinking just always retry rather that enumerate all transient errors. I think this is a good idea too. @jessesuen can you confirm what the reason for excluding (what was at the time) called as retry-able errors in #685 |
@jessesuen has agreed with me. You can retry any error and remove the |
@alexec great! I will update that |
argoproj#4144 (argoproj#4149) Signed-off-by: Alex Capras <alexcapras@gmail.com>
Summary
What happened/what you expected to happen?
We got following errors from time to time:
time="2020-09-25T14:34:34.038Z" level=error msg="executor error: etcdserver: request timed out"
Looking at the ExponentialBackoff usage in executor codes, e.g. https://github.com/argoproj/argo/blob/master/workflow/executor/executor.go#L622
It will failed earlier if the error is not transient error, the method
IsTransientErr
: https://github.com/argoproj/argo/blob/master/util/errors/errors.go#L40Seems missing case for
request timed out
Diagnostics
What version of Argo Workflows are you running?
2.10.1
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
The text was updated successfully, but these errors were encountered: