Executor hardening #685
Merged
Executor hardening #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jessesuen
commented
Jan 15, 2018
•
jessesuen
commented
- add retries and memoization for executor k8s API calls
- recover from unexpected panics and annotate the error.
jessesuen
force-pushed
the
executor-hardening
branch
3 times, most recently
from
1a732e6
to
a5ca291
Compare
jessesuen
commented
Jan 16, 2018
util/retry/retry.go
Outdated
| } | ||
|
|
||
| // IsRetryableNetworkError returns whether or not the error is a retryable network error | ||
| func IsRetryableNetworkError(err error) bool { |
There was a problem hiding this comment.
This is currently unused, and probably needs to be tweaked -- was laying the ground work for retrying artifact load/save errors.
| var pod *apiv1.Pod | ||
| var err error | ||
| _ = wait.ExponentialBackoff(DefaultRetry, func() (bool, error) { | ||
| pod, err = podsIf.Get(we.PodName, metav1.GetOptions{}) |
There was a problem hiding this comment.
The underlying client-go request seems to have some built in retry for GET. You may want to check to see if it already meets your retry requirement.
There was a problem hiding this comment.
Looks like this mechanism does not suit our needs. The issue we are trying to solve is the executor retrying getting pod/secrets from API server to address issues like this:
├-⚠ hybridize(23) hm-92j79-3168642571 failed to load artifacts: Get https://10.11.240.1:443/api/v1/namespaces/default/secrets/gcs-credentials: dial tcp 10.11.240.1:443: getsockopt: connection refused
util/retry/retry.go
Outdated
| } | ||
|
|
||
| // IsRetryableNetworkError returns whether or not the error is a retryable network error | ||
| func IsRetryableNetworkError(err error) bool { |
jessesuen
force-pushed
the
executor-hardening
branch
2 times, most recently
from
8480040
to
a3707ca
Compare
…calls Recover from unexpected panics and annotate the error.
jessesuen
force-pushed
the
executor-hardening
branch
from
a3707ca
to
789310b
Compare
sandeepbhojwani
approved these changes
Jan 17, 2018
icecoffee531
pushed a commit
to icecoffee531/argo-workflows
that referenced
this pull request
Jan 5, 2022
if the name of Sensor is "webhook-sensor", the gate-way client cannot send request to the desired sensor, so the name should be changed into "webhook"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.