Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Manifest editor not working as expected #5690

Closed
dinever opened this issue Apr 17, 2021 · 2 comments · Fixed by #5694
Closed

UI: Manifest editor not working as expected #5690

dinever opened this issue Apr 17, 2021 · 2 comments · Fixed by #5694
Assignees
@alexec
Labels
area/ui type/bug
Milestone
v3.0

Comments

@dinever
Copy link
Member

dinever commented Apr 17, 2021 •
edited
Loading

Summary

What happened/what you expected to happen?

I'm running the latest master branch. When opening up a manifest editor. I'm expecting to see the YAML view initially.

However, the current behavior is:

  1. Editor shows JSON view by default
  2. On the first click, still shows JSON view, but a different highlighting
  3. On the second click, shows YAML view now but broken highlighting

editor

Diagnostics

The chrome console didn't show any error messages. I might be able to look into it later.

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
@alexec alexec added this to the v3.0 milestone Apr 17, 2021
@alexec
Copy link
Contributor

alexec commented Apr 17, 2021

I think we should consider getting rid of the JSON editor:

  1. It is complex and buggy.
  2. I don't think it is useful to most users.

@alexec
Copy link
Contributor

alexec commented Apr 17, 2021

If we decide to do this:

  1. Delete api/jsonschema/schema.json.
  2. Remove json from new MonacoWebpackPlugin({"languages":["json","yaml"]}) is ui/src/app/webpack.config.js.
  3. Remove lang and <ToggleButton/> from <ObjectEditor/> (ui/src/app/shared/components/object-editor/object-editor.tsx)

See also #5613

@alexec alexec added the P3 label Apr 17, 2021
@alexec alexec self-assigned this Apr 17, 2021
alexec added a commit to alexec/argo-workflows that referenced this issue Apr 17, 2021
@alexec
fix(ui): Fix YAML/JSON toggle. Fixes argoproj#5690
dcef024 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked a pull request Apr 17, 2021 that will close this issue
fix(ui): Fix YAML/JSON toggle. Fixes #5690 #5694
Merged
alexec added a commit that referenced this issue Apr 19, 2021
@alexec
fix(ui): Fix YAML/JSON toggle. Fixes #5690 (#5694)
f963556
@simster7 simster7 mentioned this issue Apr 19, 2021
Closed
50 tasks
simster7 pushed a commit that referenced this issue Apr 19, 2021
@alexec @simster7
fix(ui): Fix YAML/JSON toggle. Fixes #5690 (#5694)
b7b4b3f
@agilgur5 agilgur5 changed the title Manifest editor not working as expected UI: Manifest editor not working as expected Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
area/ui type/bug
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

fix(ui): Fix YAML/JSON toggle. Fixes #5690 alexec/argo-workflows
3 participants
@alexec @dinever @agilgur5