Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Fix YAML/JSON toggle. Fixes #5690 #5694

Merged
merged 2 commits into from
Apr 19, 2021
Merged

fix(ui): Fix YAML/JSON toggle. Fixes #5690 #5694

merged 2 commits into from
Apr 19, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 17, 2021

No description provided.

@alexec
fix(ui): Fix YAML/JSON toggle. Fixes argoproj#5690
dcef024 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec added this to the v3.0 milestone Apr 17, 2021
@alexec alexec linked an issue Apr 17, 2021 that may be closed by this pull request
UI: Manifest editor not working as expected #5690
Closed
@codecov

This comment was marked as resolved.

Sign in to view
@alexec alexec marked this pull request as ready for review April 17, 2021 22:27
dinever
dinever reviewed Apr 18, 2021
View reviewed changes
Copy link
Member

@dinever dinever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One minor issue:

When clicking the "YAML" button on a pod view. It shows the JSON manifest instead by default.

Maybe we should either just rename the button to MANIFEST, or make the object editor YAML by default?

yaml

@dinever
Copy link
Member

dinever commented Apr 18, 2021

I think this PR closes #4970 as well.

@alexec alexec linked an issue Apr 18, 2021 that may be closed by this pull request
UI: Don't use a toggle for yaml where the opposite means json #4970
Closed
@dinever
Copy link
Member

dinever commented Apr 19, 2021

When clicking the "YAML" button on a pod view. It shows the JSON manifest instead by default.

Hmm.. Actually, I couldn't reproduce this anymore. I might be looking at an old workflow. Feel free to dismiss. Thanks!

@alexec
ok
60a0c4f 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec merged commit f963556 into argoproj:master Apr 19, 2021
@alexec alexec deleted the yaml branch April 19, 2021 15:45
@simster7 simster7 mentioned this pull request Apr 19, 2021
Closed
50 tasks
simster7 pushed a commit that referenced this pull request Apr 19, 2021
@alexec @simster7
fix(ui): Fix YAML/JSON toggle. Fixes #5690 (#5694)
b7b4b3f
@argoproj argoproj locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dinever dinever dinever left review comments

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees
No one assigned
Labels
area/ui
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.

UI: Manifest editor not working as expected UI: Don't use a toggle for yaml where the opposite means json
4 participants
@alexec @dinever @sarabala1979 @agilgur5