Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid container names (i.e. not "main") are allowed and causes bugs #6405

Closed
alexec opened this issue Jul 22, 2021 · 4 comments · Fixed by #6408
Closed

invalid container names (i.e. not "main") are allowed and causes bugs #6405

alexec opened this issue Jul 22, 2021 · 4 comments · Fixed by #6408
Assignees
@alexec
Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Milestone
v3.1

Comments

@alexec
Copy link
Contributor

alexec commented Jul 22, 2021

We should not allow invalid container names. It is confusing for users and costs time to investigate.

I think we can add a check here:

argo-workflows/workflow/validate/validate.go

Line 372 in 092b427

switch newTmpl.GetType() {

@stevenbressey would you be interested in helping fix this as you were impacted by this recently?
@alexec alexec changed the title invalid container names (i.e. not "main") are allow and causes bugs invalid container names (i.e. not "main") are allowed and causes bugs Jul 22, 2021
@stevenbressey
Copy link

@alexec with pleasure !
Just give me the requirements and I can start working on it next week.

@alexec
Copy link
Contributor Author

alexec commented Jul 22, 2021

I think basically if you validate a workflow, and the container is not named "main", there should be an error.

@alexec alexec self-assigned this Jul 22, 2021
@alexec alexec added this to the v3.1 milestone Jul 22, 2021
@alexec
Copy link
Contributor Author

alexec commented Jul 22, 2021

This is actually a regression.

@alexec alexec added the type/regression Regression from previous behavior (a specific type of bug) label Jul 22, 2021
@alexec
Copy link
Contributor Author

alexec commented Jul 22, 2021

feat(controller): Container set template. Closes #2551 (#5099)

alexec added a commit to alexec/argo-workflows that referenced this issue Jul 22, 2021
@alexec
fix(controller): Force main container name to be "main" as per v3.0. F…
556ea92 
…ixes argoproj#6405

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this issue Jul 22, 2021
Merged
alexec added a commit that referenced this issue Jul 23, 2021
@alexec
fix(controller): Force main container name to be "main" as per v3.0. F…
f2d24b1 
…ixes #6405 (#6408)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this issue Jul 27, 2021
Closed
39 tasks
sarabala1979 pushed a commit that referenced this issue Jul 27, 2021
@alexec @sarabala1979
fix(controller): Force main container name to be "main" as per v3.0. F…
adc17ff 
…ixes #6405 (#6408)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this issue Aug 2, 2021
Closed
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Milestone
v3.1
2 participants
@alexec @stevenbressey