Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Force main container name to be "main" as per v3.0. Fixes #6405 #6408

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jul 22, 2021

Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #6405

…ixes argoproj#6405

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec requested a review from sarabala1979 July 22, 2021 23:35
@alexec alexec added this to the v3.1 milestone Jul 22, 2021
@alexec alexec enabled auto-merge (squash) July 22, 2021 23:38
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #6408 (4c77e53) into master (2df5f66) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4c77e53 differs from pull request most recent head af88a88. Consider uploading reports for the commit af88a88 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6408      +/-   ##
==========================================
- Coverage   48.80%   48.80%   -0.01%     
==========================================
  Files         253      253              
  Lines       18151    18151              
==========================================
- Hits         8859     8858       -1     
- Misses       8324     8325       +1     
  Partials      968      968              
Impacted Files Coverage Δ
workflow/controller/workflowpod.go 74.59% <100.00%> (ø)
workflow/controller/operator.go 72.30% <0.00%> (-0.15%) ⬇️
cmd/argo/commands/get.go 59.76% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df5f66...af88a88. Read the comment docs.

@alexec alexec merged commit f2d24b1 into argoproj:master Jul 23, 2021
@alexec alexec deleted the fix-6405 branch July 23, 2021 16:20
@sarabala1979 sarabala1979 mentioned this pull request Jul 27, 2021
39 tasks
sarabala1979 pushed a commit that referenced this pull request Jul 27, 2021
…ixes #6405 (#6408)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Aug 2, 2021
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid container names (i.e. not "main") are allowed and causes bugs
2 participants