fix: Resolve issues with offline linter + add tests #10559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
commented
Feb 21, 2023
Comment on lines
+53
to
59
| err := filepath.Walk(basePath, func(path string, info os.FileInfo, err error) error { | ||
| if info.IsDir() { | ||
| return nil | ||
| } | ||
|
|
||
| if _, ok := clusterWorkflowTemplateGetter.clusterWorkflowTemplates[cwftmpl.Name]; ok { | ||
| return nil, nil, fmt.Errorf("duplicate ClusterWorkflowTemplate found: %q", cwftmpl.Name) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Reviewing without whitespace yields a nicer result here. The only real change is nesting the logic in a filepath.Walk
julienduchesne
force-pushed
the
julienduchesne/fix-issues-offline-linter
branch
from
5c82eaa
to
704cc87
Compare
julienduchesne
force-pushed
the
julienduchesne/fix-issues-offline-linter
branch
4 times, most recently
from
89e441e
to
5199512
Compare
argoproj#10059 was tested in very specific cases it seems because a couple things are wrong: - Linting directories does not work anymore - Resolving references in a namespace which doesn't show up in the given args, panics In this PR, I fix those issues but I also add functional tests that checks that all of these cases work from the cmd level I did not add to the `argo/lint/lint_test.go` tests and instead put the tests earlier down the line because the current tests do not cover the creation and configuration of the offline client Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>
julienduchesne
force-pushed
the
julienduchesne/fix-issues-offline-linter
branch
from
5199512
to
2104aba
Compare
alexec
approved these changes
Feb 22, 2023
|
Thanks for merging @alexec. FYI, I have now been able to test this internally (we use a combination of CronWorkflows, WorkflowTemplates and ClusterWorkflowTemplates, with refs between each other) and have not seen any errors. We will start using it in our CI pipeline very soon. |
8 tasks
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10059 was tested in very specific cases it seems (sorry about that 😬), because a couple things are wrong:
In this PR, I fix those issues but I also add functional tests that checks that all of these cases work from the cmd level
I did not add to the
argo/lint/lint_test.gotests and instead put the tests earlier down the line because the current tests do not cover the creation and configuration of the offline client (which is the part that is failing here, the actual linter was not modified in the PR above)make pre-commit -Bto fix codegen and lint problems.