Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve issues with offline linter + add tests #10559

Commits on Feb 22, 2023

  1. fix: Resolve issues with offline linter + add tests

    argoproj#10059 was tested in very specific cases it seems because a couple things are wrong:
    - Linting directories does not work anymore
    - Resolving references in a namespace which doesn't show up in the given args, panics
    
    In this PR, I fix those issues but I also add functional tests that checks that all of these cases work from the cmd level
    I did not add to the `argo/lint/lint_test.go` tests and instead put the tests earlier down the line because the current tests do not cover the creation and configuration of the offline client
    
    Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>
    julienduchesne committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    2104aba View commit details
    Browse the repository at this point in the history