Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Enhance docs around metrics #10767

Merged
merged 9 commits into from
Apr 3, 2023
Merged

Conversation

tico24
Copy link
Member

@tico24 tico24 commented Mar 28, 2023

The docs didn't explain the basics of the controller metrics endpoint, how to access it or how to handle multiple controllers. Adding this to the docs should reduce questions asked on the topic in Slack.

Signed-off-by: Tim Collins <tim@thecollins.team>
tico24 and others added 5 commits March 28, 2023 13:52
Signed-off-by: Tim Collins <tim@thecollins.team>
Signed-off-by: Tim Collins <tim@thecollins.team>
Signed-off-by: Tim Collins <tim@thecollins.team>
Signed-off-by: Tim Collins <tim@thecollins.team>
@tico24 tico24 mentioned this pull request Mar 28, 2023
3 tasks
Signed-off-by: Tim Collins <tim@thecollins.team>
@tico24 tico24 marked this pull request as ready for review March 30, 2023 06:34
@nicolas-vivot
Copy link

It took me the afternoon to solve this metric collection issue when running in HA.

+1 for this documentation to be updated, especially the headless configuration of the service.

Honestly, the fact that the metrics server is starting / running only on the master instance of the workflow controller is really not great. The headless service does the job to avoid to loose some metrics, but it generate tons of error message since the scraper have connection refused response when it tries to collect on the fallback instances.

Another question i have is: what happens if the master instance fall ? Do you loose all the metrics (especially the accumulated ones) or are the metrics replicated across instances, just the server not running on all ?
It would be great if the metric part has a native support for HA, instead of DIY things with a headless service.

@terrytangyuan terrytangyuan merged commit 936a7a3 into argoproj:master Apr 3, 2023
elifarley pushed a commit to elifarley/argo-workflows that referenced this pull request Apr 6, 2023
Signed-off-by: Tim Collins <tim@thecollins.team>
Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
Signed-off-by: Elifarley <elifarley@gmail.com>
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
Signed-off-by: Tim Collins <tim@thecollins.team>
Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants