kit not downloading

[tico24]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

I submitted a Documentation enhancement PR #10767

The build repeatedly fails, not on the docs ci but on the main CI. Specifically it loops over and over again with

 + curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ jq -r .tag_name
+ tag=
+ [  =  ]
+ jq -r .tag_name
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ tag=
+ [  =  ]
+ jq -r .tag_name
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ tag=
+ [  =  ]
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ jq -r .tag_name
+ tag=
+ [  =  ]
+ jq -r .tag_name
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ tag=
+ [  =  ]
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ jq -r .tag_name
+ tag=
+ [  =  ]
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ jq -r .tag_name
+ tag=
+ [  =  ]
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ jq -r .tag_name
+ tag=
+ [  =  ]
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ jq -r .tag_name
+ tag=
+ [  =  ]
+ jq -r .tag_name
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ tag=
+ [  =  ]
+ jq -r .tag_name
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ tag=
+ [  =  ]
+ jq -r .tag_name
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ tag=
+ [  =  ]
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ jq -r .tag_name
+ tag=
+ [  =  ]
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ jq -r .tag_name
+ tag=
+ [  =  ]
+ jq -r .tag_name
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest
+ tag=
+ [  =  ]
+ jq -r .tag_name
+ curl -fsL https://api.github.com/repos/kitproj/kit/releases/latest

I see little benefit on wasting CPU cycles testing the code that hasn't changed, and this blocks me getting my PR for review.

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

n/a

Logs from the workflow controller

n/a

Logs from in your workflow's wait container

n/a

[terrytangyuan]

It looks passing now

[tico24]

@terrytangyuan this is not the case. Still failing for the same reason: https://github.com/argoproj/argo-workflows/actions/runs/4550791846/jobs/8024160087?pr=10767

[terrytangyuan]

@alexec Could you take a look?

[alexec]

@terrytangyuan shall I add you as contributor to kit?

[tico24]

Failing for this PR too: #10778

[alexec]

If anyone can explain why a simple curl command fails, I’d love to know. I’m lost.

[tico24]

Maybe drop the -s to see why it's failing?

The -f won't work if it's getting a 401 for example, and supressing the failure seems to be doing more harm than good anyway?

My guess besides "github actions suck" is its something to do with being inside the github ecosystem is making it require auth or something.

[alexec]

Good idea I’ll add -v and we can hopefully diagnose the issue.

[alexec]

Done.

[tico24]

Looks like GitHub rate limits it's own access to the api.

So the only solutions I see are:

• Don't host kit on a GitHub api endpoint.

• Don't run ci on GitHub.

[terrytangyuan]

Also try authenticating the GitHub API requests to avoid rate-limiting?

[tico24]

@terrytangyuan do you have access to secrets in this repo? Otherwise @alexec will have to make this change.

[terrytangyuan]

Only @alexec and @sarabala1979

[terrytangyuan]

@alexec We hit this quite frequently recently. Would you mind taking a look whenever you get a chance?