Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify DinD usage on newer k8s versions #10778

Merged
merged 5 commits into from
Mar 30, 2023

Conversation

tico24
Copy link
Member

@tico24 tico24 commented Mar 29, 2023

Docker in Docker is (to all intents and purposes) not possible in k8s 1.24+

We still support older versions of k8s so I didn't want to just delete this page, but we should make it clear that DinD isn't a cool thing to be trying on modern k8s.

Signed-off-by: Tim Collins <tim@thecollins.team>
Signed-off-by: Tim Collins <tim@thecollins.team>
tico24 and others added 3 commits March 29, 2023 16:35
Signed-off-by: Tim Collins <tim@thecollins.team>
Signed-off-by: Tim Collins <tim@thecollins.team>
@tico24 tico24 mentioned this pull request Mar 30, 2023
3 tasks
@tico24 tico24 marked this pull request as ready for review March 30, 2023 08:52
@terrytangyuan terrytangyuan merged commit 6cdb66f into argoproj:master Mar 30, 2023
elifarley pushed a commit to elifarley/argo-workflows that referenced this pull request Apr 6, 2023
Signed-off-by: Tim Collins <tim@thecollins.team>
Signed-off-by: Elifarley <elifarley@gmail.com>
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
Signed-off-by: Tim Collins <tim@thecollins.team>
@agilgur5 agilgur5 added the area/docs Incorrect, missing, or mistakes in docs label May 11, 2024
@agilgur5
Copy link
Member

Apparently DinD is actually still possible without dockershim and the docker:dind sidecar in this example already includes Docker Engine to make that possible. C.f. #13010 (comment), https://aws.amazon.com/blogs/containers/all-you-need-to-know-about-moving-to-containerd-on-amazon-eks/.
Buildkit, Kaniko, etc would still be preferred, so just the DinD part needs correction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants