fix: always fail dag when shutdown is enabled. Fixes #11452 #11493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: isubasinghe <isitha@pipekit.io>
|
|
isubasinghe
commented
Aug 1, 2023
isubasinghe
force-pushed
the
upstream-stop-on-shutdown
branch
from
4c2e3ea to
2c63eb0
Compare
Signed-off-by: isubasinghe <isitha@pipekit.io>
isubasinghe
force-pushed
the
upstream-stop-on-shutdown
branch
from
6211bc0 to
825c7bf
Compare
Signed-off-by: isubasinghe <isitha@pipekit.io>
agilgur5
approved these changes
Aug 3, 2023
| @@ -140,15 +146,24 @@ func (d *dagContext) assessDAGPhase(targetTasks []string, nodes wfv1.Nodes) wfv1 | |||
| targetTaskPhases[d.taskNodeID(task)] = "" | |||
| } | |||
|
|
|||
| boundaryNode, err := nodes.Get(d.boundaryID) | |||
There was a problem hiding this comment.
for context for other readers, the nodes.Get modifications here are just error guards a la #11451. no real semantic changes
7 tasks
45 tasks
Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
terrytangyuan
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11452
Motivation
Ensure that stopped workflows are always marked as Failed (as expected).
Modifications
When shutdown is enabled, we don't do the DAG exploration.
Verification
Manually tested