Release v3.4.11 cherry-pick candidates

[terrytangyuan]

This issue tracks commits for 3.4.11 patch release.

• fix: Fixed parent level memoization broken. Fixes #11612 #11623 cc @shmruin Please submit a PR to https://github.com/argoproj/argo-workflows/tree/release-3.4.11

The following commits could not be cherry-picked previously into v3.4.10 release branch since diverges from master branch too much and have non-trivial conflicts to resolve. If you'd like to get them into v3.4.11 release, please submit a PR to the release branch. https://github.com/argoproj/argo-workflows/tree/release-3.4.11

• 61a4ac4 fix: Ignore failed read of exit code. @alexec
• b26f5b8 fix: Support OOMKilled with container-set. @alexec
• 1f6b19f fix: add guard against NodeStatus. @isubasinghe
• 105031b fix: always fail dag when shutdown is enabled. @isubasinghe

[SlaterByte]

@terrytangyuan Would love to see this get prioritized. Unfortunately still in Draft:
#9058

This PR was also brought up in "Release v3.4.6 cherry-pick candidates" #10747

@rohankmr414 would need to get this changed from Draft to "Ready for Review". @caelan-io suggested there's a few sticky remaining thorns to sort out? There's no mention on the PR or any outstanding issues though.

Alternatively, maybe something to be wrangled in for a v3.5 release?

[agilgur5]

#11569 was waiting for a new patch

[agilgur5]

#11626, #11625, and #11624 would be good to get in for the CLI as they are frequent areas of confusion for users (two test flakes need retries there)

EDIT: this was successfully cherry-picked below ✅

[isubasinghe]

#11665
#11667

[toyamagu-2021]

Any chance to include #11634 #11682?

[terrytangyuan]

We are planning to release it by the end of Friday. Please send a PR to the release branch by the end of Thursday so I can release it on Friday. https://github.com/argoproj/argo-workflows/tree/release-3.4.11

[terrytangyuan]

To cherry-pick (the checked items from the list are the ones we successfully cherry-picked):

• 297bea6 fix: Argo DB init conflict when deploy workflow-controller with multiple replicas Argo DB init conflict when deploy workflow-controller with multiple replicas #11177 (fix: Argo DB init conflict when deploy workflow-controller with multiple replicas #11177 #11569)
• c31132d docs: Correct links in release notes template (docs: Correct links in release notes template #11708)
• 12da114 docs(cli): a stopped workflow cannot be resumed (docs(cli): a stopped workflow cannot be resumed #11624
• 0cffdff docs(cli): clarify the difference b/t retry and resubmit (docs(cli): clarify the difference b/t retry and resubmit #11625)
• d74929a docs(cli): clarify stop v. terminate with Long descriptions (docs(cli): clarify stop v. terminate with Long descriptions #11626)
• f5e31f8 fix: offset reset when pagination limit onchange (fix: offset reset when pagination limit onchange #11703)
• d3cb451 fix(workflow): match discovery burst and qps for kubectl with upstream kubectl binary (fix(resource): match discovery burst and qps for kubectl with upstream kubectl binary #11603)
• d99efa7 fix: ensure labels is defined before key access. Fixes UI - label undefined for some workflows #11602 (fix: ensure labels is defined before key access. Fixes #11602 #11638)
• 363ee69 fix: upgrade module for pull image in google cloud issue Image pull error: User "system:serviceaccount:argo:argo-helm-argo-workflows-workflow-controller" cannot get resource "secrets" in API group "" in the namespace "mynamespace" #9630
• 8a52da5 fix: TERM signal was catched but not handled properly, which causing … (fix(resource): properly handle TERM signal after catch #11582)
• 027b9c9 fix: override storedWorkflowSpec when override parameter (Overriding parameter to retry workflow does not work when using WorkflowTempalate #11631)
• 2882190 fix: Upgrade Go to v1.21 Fixes go 1.21 upgrade #11556 (build: upgrade Go to v1.21. Fixes #11556 #11601)
• 18820c3 fix: Make defaultWorkflow hooks work more than once (fix: Make defaultWorkflow hooks work more than once #11693)
• 9cb3783 fix: cron workflow initial filter value. Fixes ui: Cron workflow initial filter value #11685 (fix: cron workflow initial filter value. Fixes #11685 #11686)
• fix(ui): don't use anti-pattern in CheckboxFilter #11739
• ba523bf fix: Change node in paramScope to taskNode at executeDAG (lifecycle hooks executed when conditions are not met(DAG) #11422) (fix: Change node in paramScope to taskNode at executeDAG (#11422) #11682)
• bc9b644 fix: argo logs completion (fix: argo logs completion #11645)
• cb8dbbc fix: Print valid JSON/YAML when workflow list empty argo list -o json should output JSON when no workflows found #10873 (fix: Print valid JSON/YAML when workflow list empty #10873 #11681)
• 9693c02 fix: Fixed parent level memoization broken. Fixes parent level memoization is broken #11612 (fix: Fixed parent level memoization broken. Fixes #11612 #11623)
• 9317360 fix: do not process withParams when task/step Skipped. Fixes withParams processed even when task/step Skipped #10173 (fix: do not process withParams when task/step Skipped. Fixes #10173 #11570)
• c9c6e5c fix: deprecated Link(Help-Contact) Issue (fix: deprecated Slack Link in Help page Contact #11627)
• 23d6da6 fix: upgrade base image for security and build support arm64 argosay uses amd64 architecture instead of arm64 on arm64 machine #10435 (fix: upgrade argosay image for security and build support arm64 #10435 #11613)
• 143d0f5 fix: Fixed memoization is unchecked after mutex synchronization. Fixes Mutex check happens after memoization cache check and lock info missing from UI #11219 (fix: Fixed memoization is unchecked after mutex synchronization. Fixes #11219 #11456)
• f8a34a3 fix: Devcontainer resets /etc/hosts (The container created by Devcontainer keeps resetting /etc/hosts #11439) (fix: Devcontainer resets /etc/hosts (#11439) #11440)
• c6a2a4f fix: Apply the creator labels about the user who resubmitted a Workflow (fix: Apply the creator labels about the user who resubmitted a Workflow #11415)
• f5d41f8 fix: make archived logs more human friendly in UI (fix: make archived logs more human friendly in UI #11420)

Other candidates (will move the appropriate ones to the "to cherry-pick" section above. The ones listed below are not included in this release):

9e7dc25 fix(ui): don't reload the page until after deletion (#11711)
e90d6bf fix: Health check from lister not apiserver (#11375)
27f1227 fix: Add missing new version modal for v3.5 (#11692)
ac9e2de fix: Surface underlying error when getting a workflow (#11674)
f18b339 fix(ui): Only redirect/reload to wf list page when wf deletion succeeds (#11676)
82ac980 fix: Only confirm DB deletion when there are archived workflows. Fixes #11658 (#11659)
0423eb6 fix(ui): ensure package.json#name is not the same as argo-ui (#11595)
6bccc99 fix: upgrade argo-ui components to latest (#11585)
1fd6e40 fix: fail test on pr #11368 (#11576)
b26f5b8 fix: Support OOMKilled with container-set. Fixes #10063 (#11484)
61a4ac4 fix: Ignore failed read of exit code. Fixes #11490 (#11496)
5cb75d9 fix: add query string to workflow detail page(#11371) (#11373)
5b31ca1 fix: persist archived workflows with Persisted label (#11367) (#11413)
97b6fa8 fix: Modify broken ui by archived col (#11366)
fdb3ec0 fix: Live workflow takes precedence during merge to correctly display in the UI (#11336)
ac9161c fix: Workflow list page crashes for workflow rows without labels (#11195)
2016078 fix: add space to fix release action issue (#11160)

[terrytangyuan]

Only the checked items from the list above are successfully cherry-picked. Any remaining ones would require a separate PR into the release branch.

[terrytangyuan]

Merged #11757

[terrytangyuan]

Tag created https://github.com/argoproj/argo-workflows/releases/tag/v3.4.11