fix: add guard against NodeStatus. Fixes #11102 -- 3.4 backport #11665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: isubasinghe <isitha@pipekit.io> fix: get rid of return for Set, remove logs Signed-off-by: isubasinghe <isitha@pipekit.io> fix: has returns correct value Signed-off-by: isubasinghe <isitha@pipekit.io> fix: remove debug logs Signed-off-by: isubasinghe <isitha@pipekit.io> fix: ensure tests pass Signed-off-by: isubasinghe <isitha@pipekit.io> fix: restore back to /bin/bash Signed-off-by: isubasinghe <isitha@pipekit.io> fix: remove logging Signed-off-by: isubasinghe <isitha@pipekit.io> fix: remove logrus and replace with log Signed-off-by: isubasinghe <isitha@pipekit.io> fix: replace panic with errors Signed-off-by: isubasinghe <isitha@pipekit.io> fix: add comments and use Get for helper fn Signed-off-by: isubasinghe <isitha@pipekit.io> fix: always diagnose as failed when shutdown Signed-off-by: Isitha Subasinghe <isitha@pipekit.io> fix: remove error return in taskresult reconcilation Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Signed-off-by: isubasinghe <isitha@pipekit.io>
isubasinghe
changed the title
This was referenced Aug 24, 2023
terrytangyuan
approved these changes
Aug 24, 2023
Closed
3 tasks
|
For posterity, as it may not be immediately obvious to a reader, this is a backport of #11451 for the 3.4.11+ patch series |
agilgur5
added
the
type/backport
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
agilgur5
changed the title
agilgur5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.