Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add guard against NodeStatus. Fixes #11102 -- 3.4 backport #11665

Merged
merged 6 commits into from
Aug 24, 2023
Merged

fix: add guard against NodeStatus. Fixes #11102 -- 3.4 backport #11665

merged 6 commits into from
Aug 24, 2023

Commits on Aug 24, 2023

  1. fix: add guard against NodeStatus 

    Signed-off-by: isubasinghe <isitha@pipekit.io>

fix: get rid of return for Set, remove logs

Signed-off-by: isubasinghe <isitha@pipekit.io>

fix: has returns correct value

Signed-off-by: isubasinghe <isitha@pipekit.io>

fix: remove debug logs

Signed-off-by: isubasinghe <isitha@pipekit.io>

fix: ensure tests pass

Signed-off-by: isubasinghe <isitha@pipekit.io>

fix: restore back to /bin/bash

Signed-off-by: isubasinghe <isitha@pipekit.io>

fix: remove logging

Signed-off-by: isubasinghe <isitha@pipekit.io>

fix: remove logrus and replace with log

Signed-off-by: isubasinghe <isitha@pipekit.io>

fix: replace panic with errors

Signed-off-by: isubasinghe <isitha@pipekit.io>

fix: add comments and use Get for helper fn

Signed-off-by: isubasinghe <isitha@pipekit.io>

fix: always diagnose as failed when shutdown

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>

fix: remove error return in taskresult reconcilation

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
    @isubasinghe
    isubasinghe committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    767362b View commit details
    Browse the repository at this point in the history

  2. fix: handler error for GetNodeByName in hooks.go 

    Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
    @isubasinghe
    isubasinghe committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ae29f9b View commit details
    Browse the repository at this point in the history

  3. fix: ensure access via setter for NodeStatus 

    Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
    @isubasinghe
    isubasinghe committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    2f50374 View commit details
    Browse the repository at this point in the history

  4. fix: added err assertion for operator test cases 

    Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
    @isubasinghe
    isubasinghe committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    04362df View commit details
    Browse the repository at this point in the history

  5. fix: remove err checking for hooks 

    Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
    @isubasinghe
    isubasinghe committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ea18c2d View commit details
    Browse the repository at this point in the history

  6. fix: remove err handling in hook 

    Signed-off-by: isubasinghe <isitha@pipekit.io>
    @isubasinghe
    isubasinghe committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    5cea4b7 View commit details
    Browse the repository at this point in the history