fix: upgrade module for pull image in google cloud. fixes #9630 #11614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrytangyuan
approved these changes
Aug 19, 2023
auto-merge was automatically disabled
August 19, 2023 11:16
Head branch was pushed to by a user without write access
|
dependabot is updating modules. Just wait after that, we can update for this |
Signed-off-by: Son Bui <sonbv00@gmail.com>
|
@terrytangyuan help me check again. The dependabot changed the go.mod and make conflict on this issue. I've updated to resolve the conflict |
terrytangyuan
approved these changes
Aug 22, 2023
5 tasks
agilgur5
added
type/dependencies
agilgur5
changed the title
agilgur5
added
the
area/upstream
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 6, 2024
argoproj#11614) Signed-off-by: Son Bui <sonbv00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9630
Motivation
Pull image in Google Cloud issue google/go-containerregistry#1346
Modifications
Upgrade module
github.com/google/go-containerregistry/pkg/authn/k8schain(old v0.9.0) (match withgithub.com/google/go-containerregistryv0.11.0)Verification
make test
google/go-containerregistry#1346
Note
Why not upgrade
github.com/google/go-containerregistry/pkg/authn/k8schainandgithub.com/google/go-containerregistryto latest version 0.16.1?-> Upgrade to the latest version for both, upgrade other dependencies and break other code when build. So just upgrade
github.com/google/go-containerregistry/pkg/authn/k8schainto match with our currentgithub.com/google/go-containerregistry v0.11.0