-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): replace outdated whalesay
image with busybox
#13429
Conversation
- also instead of `cowsay`, use `echo` - rename several templates that were named `whalesay` unnecessarily as well - they often just printed a message, and so are now named `print-message` - some didn't even use the `whalesay` image and so seemed erroneously named - others always printed "hello world", and so are now named `hello-world` - also clarify a few other template names that would do more than print a message - now named `print-message-from-file` or `hello-world-to-file` - plus make some small style adjustments per the style guide while at it - and remove some trailing newlines in codeblocks Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Thanks for doing this.
Oh, nice. I was going to ask about that. |
It actually didn't run here apparently since no source or test code changed 😕 Changing the diff detection is actually a little easier said than done though, as it wraps the whole E2E matrix, and this is only one of the test suites. The more correct way to do it would probably be to split off the examples from the matrix as its own job that runs if the e2es should run or if the examples changed. But that may require a pretty decent-sized refactor.
I've also been meaning to replace many of the docs examples with embeds to the |
See argoproj/argo-workflows#13429 Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
See argoproj/argo-workflows#13429 Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
See argoproj/argo-workflows#13429 Fixes Python for upstream files so `make regenerate-test-data` works as expected (to unblock #1157) Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
…#13429) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Fixes #11858, Fixes #13388, Fixes #12767 (comment)
Motivation
The
whalesay
image was last updated 9 years ago and does not support Docker Manifest v2 norarm64
architectures.Per docker/whalesay#6, where I tweeted at Docker and emailed support twice, Docker has no intention to update the image (it just requires a rebuild, that's it... 🤷 ) nor even mark it as deprecated or archived... 😕
Modifications
whalesay
image withbusybox
imagecowsay
, use plainecho
busybox
in tested examplessecondary modifications
rename several templates that were named
whalesay
unnecessarily as wellprint-message
hello-world
whalesay
image, and so are now named more accordinglyalso clarify a few other template names that would do more than print a message
print-message-from-file
orhello-world-to-file
plus make some small style adjustments per the docs style guide while at it
Verification
whalesay
orcowsay
indocs
andexamples
whalesay
is very intentionally used as a manifest v1 example. also a fewcowsay
ones leftover are all from theargosay
image, see "Future Work" belowFuture Work
argosay
as well and remove theargosay
build entirely from the codebaseargosay
image for security and build support arm64 #10435 #11613 (comment)argosay
andwhalesay
in all tests