Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): use sh instead of bash with busybox #13508

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

chengjoey
Copy link
Contributor

@chengjoey chengjoey commented Aug 27, 2024

create examples/work-avoidance.yaml
echo pod occur error:

Error: failed to find name in PATH: exec: "bash": executable file not found in $PATH

Motivation

use sh instead of bash

Modifications

Verification

Signed-off-by: joey <zchengjoey@gmail.com>
@agilgur5 agilgur5 changed the title chore: examples busybox image command sh fix(docs): use sh instead of bash with busybox Aug 27, 2024
@agilgur5 agilgur5 added the area/docs Incorrect, missing, or mistakes in docs label Aug 27, 2024
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Aug 27, 2024
Copy link
Contributor

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, follow-up to #13429, nice catch!
Were there any other uses of bash you could find?

Most of the commands were echo or cowsay/whalesay but I guess there were some nuanced scripts like this one too

@agilgur5
Copy link
Contributor

agilgur5 commented Aug 27, 2024

Answering my own question, did a search and the rest use other images. Some of them do use argosay though, which is slated for removal as well, so those will need to be careful around in future PRs

@chengjoey
Copy link
Contributor Author

Were there any other uses of bash you could find?

I checked all the busybox examples, and only found this one using bash. others all use sh or directly use command (echo, true, mkdir etc)

Copy link
Contributor

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and thanks for double-checking other examples!

@agilgur5 agilgur5 merged commit 6d42688 into argoproj:main Aug 27, 2024
18 checks passed
Joibel pushed a commit to pipekit/argo-workflows that referenced this pull request Sep 19, 2024
Signed-off-by: joey <zchengjoey@gmail.com>
Joibel pushed a commit that referenced this pull request Sep 20, 2024
Signed-off-by: joey <zchengjoey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants