feat(ui): Add Template/Cron workflow filter to workflow page. Closes #4532 #4543

tczhao · 2020-11-17T04:24:11Z

Signed-off-by: Tianchu Zhao evantczhao@gmail.com

Checklist:

My organization is added to USERS.md.

Closes #4532

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

CLAassistant · 2020-11-17T04:24:17Z

All committers have signed the CLA.

alexec

Looks good.

Do you think you could extract the drop-downs into shared code so we can reuse them?
Can I ask for screenshots to be attached?

ui/src/app/workflows/components/workflow-filters/workflow-filters.tsx

…placeholder to empty to align with other filters Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

tczhao · 2020-11-18T16:10:30Z

Hi, I've added the organization.
I'm not sure if the LinkedIn link from my GitHub profile is enough to verify that I work for the org.
Otherwise, I can send you a message using org email from slack to prove it.

alexec · 2020-11-18T17:38:43Z

ui/src/app/shared/components/dropdown.tsx

+    onChange: (value: string) => void;
+}
+
+export class Dropdown extends React.Component<Props, { selected: string }> {


Can I get you to change this into a stateless component? They are much more robust and I think we want to move away from class components.

https://reactjs.org/docs/hooks-intro.html

do you mean that

use functional component instead of class component

and/or do not use conditional rendering inside the component, instead, pass the display value from the caller?

functional component instead

updated to functional component

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

alexec

One last change.

alexec · 2020-11-19T16:52:34Z

ui/src/app/shared/components/dropdown.tsx

+import * as React from 'react';
+import { DataLoader, Select, SelectOption } from 'argo-ui';
+
+export const Dropdown = (props: {load: Promise<(string | SelectOption)[]>; onChange: (value: string) => void}) => {


Have about calling this DataLoaderDropdown?

How about the filename?

data-loader-dropdown.tsx

updated to DataLoaderDropdown

alexec · 2020-11-19T17:40:09Z

Please run yarn lint to fix lint errors.

…workflow-filters Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

alexec · 2020-11-19T18:25:47Z

THank you!

…rgoproj#4532 (argoproj#4543) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Signed-off-by: github@finnesand.no <github@finnesand.no> feat(ui): Add Template/Cron workflow filter to workflow page. Closes argoproj#4532 (argoproj#4543) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> feat(executor): Auto create s3 bucket if not present. Signed-off-by: Alex Capras <alexcapras@gmail.com> Apply codegen Signed-off-by: Alex Capras <alexcapras@gmail.com> Add argo-e2e label to test wf Signed-off-by: Alex Capras <alexcapras@gmail.com> chore: Updated stress test YAML (argoproj#4569) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Updated kubectl apply command in manifests README (argoproj#4577) Signed-off-by: Stefan Gloutnikov <stefan@gloutnikov.com> feat(controller): Make MAX_OPERATION_TIME configurable. Close argoproj#4239 (argoproj#4562) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix a typo in example (argoproj#4590) Signed-off-by: Takayoshi Nishida <takayoshi.nishida@gmail.com> feat(controller): Retry transient offload errors. Resolves argoproj#4464 (argoproj#4482) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(server): use the correct name when downloading artifacts (argoproj#4579) Signed-off-by: Daniel Herman <dherman@factset.com> fix(server): serve artifacts directly from disk to support large artifacts (argoproj#4589) Signed-off-by: Daniel Herman <dherman@factset.com> fix(executor): Handle sidecar killing in a process-namespace-shared pod (argoproj#4575) Signed-off-by: Daisuke Taniwaki <daisuketaniwaki@gmail.com> docs: Add JSON schema for IDE validation (argoproj#4581) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> refactor: Use polling model for workflow phase metric (argoproj#4557) Signed-off-by: Simon Behar <simbeh7@gmail.com> Addressing reviewers comments Signed-off-by: Alex Capras <alexcapras@gmail.com> Addressing reviewers comments docs: Minor typo fix (argoproj#4610) Signed-off-by: Paavo Pokkinen <paavo.pokkinen@vaimo.com> fix(controller): Prevent tasks with names starting with digit to use either 'depends' or 'dependencies' (argoproj#4598) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> fix(docs): Bring minio chart instructions up to date (argoproj#4586) Signed-off-by: Ranga Krishnan <ranga@bei.re> fix(executor): Fixed waitMainContainerStart returning prematurely. Closes argoproj#4599 (argoproj#4601) Signed-off-by: fsiegmund <siegmund@slb.com> feat(controller): Enhanced artifact repository ref. See argoproj#3184 (argoproj#4458) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: Null check pagination variable (argoproj#4617) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix: Perform fields filtering server side (argoproj#4595) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(server): Correct webhook event payload marshalling. Fixes argoproj#4572 (argoproj#4594) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(ui): Add columns--narrower-height to AttributeRow (argoproj#4371) fix: Fix TestCleanFieldsExclude (argoproj#4625) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(argo-server): fix global variable validation error with reversed dag.tasks (argoproj#4369) Signed-off-by: chenyu.zheng <chenyu.zheng@hulu.com> fix: derive jsonschema and fix up issues, validate examples dir… (argoproj#4611) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> fix(ui): Reference secrets in EnvVars. Fixes argoproj#3973 (argoproj#4419) Signed-off-by: Alejandro Tejera <aletepe@gmail.com> fix(ui): Fix Snyk issues (argoproj#4631) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(executor): More informative log when executors do not support output param from base image layer (argoproj#4620) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> Codegen patch. Signed off by alexcapras@gmail.com Codegen patch. Signed off by alexcapras@gmail.com Delete test.patch

Signed-off-by: github@finnesand.no <github@finnesand.no> feat(ui): Add Template/Cron workflow filter to workflow page. Closes argoproj#4532 (argoproj#4543) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> feat(executor): Auto create s3 bucket if not present. Signed-off-by: Alex Capras <alexcapras@gmail.com> Apply codegen Signed-off-by: Alex Capras <alexcapras@gmail.com> Add argo-e2e label to test wf Signed-off-by: Alex Capras <alexcapras@gmail.com> chore: Updated stress test YAML (argoproj#4569) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Updated kubectl apply command in manifests README (argoproj#4577) Signed-off-by: Stefan Gloutnikov <stefan@gloutnikov.com> feat(controller): Make MAX_OPERATION_TIME configurable. Close argoproj#4239 (argoproj#4562) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix a typo in example (argoproj#4590) Signed-off-by: Takayoshi Nishida <takayoshi.nishida@gmail.com> feat(controller): Retry transient offload errors. Resolves argoproj#4464 (argoproj#4482) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(server): use the correct name when downloading artifacts (argoproj#4579) Signed-off-by: Daniel Herman <dherman@factset.com> fix(server): serve artifacts directly from disk to support large artifacts (argoproj#4589) Signed-off-by: Daniel Herman <dherman@factset.com> fix(executor): Handle sidecar killing in a process-namespace-shared pod (argoproj#4575) Signed-off-by: Daisuke Taniwaki <daisuketaniwaki@gmail.com> docs: Add JSON schema for IDE validation (argoproj#4581) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> refactor: Use polling model for workflow phase metric (argoproj#4557) Signed-off-by: Simon Behar <simbeh7@gmail.com> Addressing reviewers comments Signed-off-by: Alex Capras <alexcapras@gmail.com> Addressing reviewers comments docs: Minor typo fix (argoproj#4610) Signed-off-by: Paavo Pokkinen <paavo.pokkinen@vaimo.com> fix(controller): Prevent tasks with names starting with digit to use either 'depends' or 'dependencies' (argoproj#4598) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> fix(docs): Bring minio chart instructions up to date (argoproj#4586) Signed-off-by: Ranga Krishnan <ranga@bei.re> fix(executor): Fixed waitMainContainerStart returning prematurely. Closes argoproj#4599 (argoproj#4601) Signed-off-by: fsiegmund <siegmund@slb.com> feat(controller): Enhanced artifact repository ref. See argoproj#3184 (argoproj#4458) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: Null check pagination variable (argoproj#4617) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix: Perform fields filtering server side (argoproj#4595) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(server): Correct webhook event payload marshalling. Fixes argoproj#4572 (argoproj#4594) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(ui): Add columns--narrower-height to AttributeRow (argoproj#4371) fix: Fix TestCleanFieldsExclude (argoproj#4625) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(argo-server): fix global variable validation error with reversed dag.tasks (argoproj#4369) Signed-off-by: chenyu.zheng <chenyu.zheng@hulu.com> fix: derive jsonschema and fix up issues, validate examples dir… (argoproj#4611) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> fix(ui): Reference secrets in EnvVars. Fixes argoproj#3973 (argoproj#4419) Signed-off-by: Alejandro Tejera <aletepe@gmail.com> fix(ui): Fix Snyk issues (argoproj#4631) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(executor): More informative log when executors do not support output param from base image layer (argoproj#4620) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> Codegen patch. Signed off by alexcapras@gmail.com Codegen patch. Signed off by alexcapras@gmail.com Delete test.patch Signed-off-by: Alex Capras <alexcapras@gmail.com>

tczhao added 2 commits November 17, 2020 14:50

feat(ui): display common cron,template workflow filter in label

670e461

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

feat(ui): add cron,template workflow selection filter

54fef2c

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

alexec requested changes Nov 17, 2020

View reviewed changes

ui/src/app/workflows/components/workflow-filters/workflow-filters.tsx Show resolved Hide resolved

alexec self-assigned this Nov 17, 2020

refactor(ui): use share component NamespaceFilter in report, default …

04184a4

…placeholder to empty to align with other filters Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

tczhao force-pushed the master branch from 9460fa9 to 8aed4f3 Compare November 18, 2020 15:27

alexec reviewed Nov 18, 2020

View reviewed changes

docs(users): add Woolworths group

d612e71

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

tczhao force-pushed the master branch from 475d3bc to c7b8dcf Compare November 19, 2020 06:05

alexec requested changes Nov 19, 2020

View reviewed changes

tczhao force-pushed the master branch from c7b8dcf to 5461549 Compare November 19, 2020 17:10

refactor(ui): extract share component DataLoaderDropdown from report,…

ed29e2e

…workflow-filters Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

tczhao force-pushed the master branch from 58ba47e to ed29e2e Compare November 19, 2020 17:53

alexec approved these changes Nov 19, 2020

View reviewed changes

alexec added 2 commits November 19, 2020 10:03

Merge branch 'master' into master

066ffb5

Merge branch 'master' into master

d6421c1

alexec merged commit 916b454 into argoproj:master Nov 19, 2020

alexec added this to the v3.0 milestone Nov 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): Add Template/Cron workflow filter to workflow page. Closes #4532 #4543

feat(ui): Add Template/Cron workflow filter to workflow page. Closes #4532 #4543

tczhao commented Nov 17, 2020 •

edited

Loading

CLAassistant commented Nov 17, 2020 •

edited

Loading

alexec left a comment

tczhao commented Nov 18, 2020

alexec Nov 18, 2020

tczhao Nov 18, 2020

alexec Nov 19, 2020

tczhao Nov 19, 2020

alexec left a comment

alexec Nov 19, 2020

tczhao Nov 19, 2020

alexec Nov 19, 2020

tczhao Nov 19, 2020

alexec commented Nov 19, 2020

alexec commented Nov 19, 2020

feat(ui): Add Template/Cron workflow filter to workflow page. Closes #4532 #4543

feat(ui): Add Template/Cron workflow filter to workflow page. Closes #4532 #4543

Conversation

tczhao commented Nov 17, 2020 • edited Loading

CLAassistant commented Nov 17, 2020 • edited Loading

alexec left a comment

Choose a reason for hiding this comment

tczhao commented Nov 18, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexec left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexec commented Nov 19, 2020

alexec commented Nov 19, 2020

tczhao commented Nov 17, 2020 •

edited

Loading

CLAassistant commented Nov 17, 2020 •

edited

Loading