docs: Add JSON schema for IDE validation #4581

brabster · 2020-11-21T20:50:14Z

Checklist:

My organization is added to USERS.md - I'm a consultant

See #4477

Adds JSON Schema validation as the first IDE support method, with instructions for IDEA and VSCode
Deletes existing CRD validation approach

CLAassistant · 2020-11-21T20:50:18Z

All committers have signed the CLA.

docs/ide-setup.md

brabster

No review necessary from me

brabster · 2020-11-23T22:22:08Z

docs/ide-setup.md

-Use either VS Code or Kubernetes and load the full Custom Resource Definitions (CRDs) into an IDE that support CRD validation (e.g IntelliJ, VS Code).
+Argo provides a [JSON Schema](https://tbc/schema.json) that enables validation of YAML resources in your IDE.
+
+### IntelliJ IDEA (Community & Utimate Editions)


IDEA instructions for JSON Schema @alexec

docs/ide-setup.md

alexec · 2020-11-24T00:44:18Z

Still WIP?

alexec

LGTM

alexec · 2020-11-24T00:45:59Z

@brabster can you do the DCO please?

Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

…up workflows and archiving (argoproj#4549) Signed-off-by: Zach Brown <github@prozach.org> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Signed-off-by: Simon Behar <simbeh7@gmail.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Signed-off-by: github@finnesand.no <github@finnesand.no> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

…rgoproj#4532 (argoproj#4543) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Signed-off-by: Stefan Gloutnikov <stefan@gloutnikov.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

…j#4239 (argoproj#4562) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

…warn Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

brabster · 2020-11-24T08:54:50Z

Sorted sorry hadn't seen DCO before! Also sorted WIP label etc.

alexec · 2020-11-24T18:49:57Z

LGTM!

Signed-off-by: github@finnesand.no <github@finnesand.no> feat(ui): Add Template/Cron workflow filter to workflow page. Closes argoproj#4532 (argoproj#4543) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> feat(executor): Auto create s3 bucket if not present. Signed-off-by: Alex Capras <alexcapras@gmail.com> Apply codegen Signed-off-by: Alex Capras <alexcapras@gmail.com> Add argo-e2e label to test wf Signed-off-by: Alex Capras <alexcapras@gmail.com> chore: Updated stress test YAML (argoproj#4569) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Updated kubectl apply command in manifests README (argoproj#4577) Signed-off-by: Stefan Gloutnikov <stefan@gloutnikov.com> feat(controller): Make MAX_OPERATION_TIME configurable. Close argoproj#4239 (argoproj#4562) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix a typo in example (argoproj#4590) Signed-off-by: Takayoshi Nishida <takayoshi.nishida@gmail.com> feat(controller): Retry transient offload errors. Resolves argoproj#4464 (argoproj#4482) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(server): use the correct name when downloading artifacts (argoproj#4579) Signed-off-by: Daniel Herman <dherman@factset.com> fix(server): serve artifacts directly from disk to support large artifacts (argoproj#4589) Signed-off-by: Daniel Herman <dherman@factset.com> fix(executor): Handle sidecar killing in a process-namespace-shared pod (argoproj#4575) Signed-off-by: Daisuke Taniwaki <daisuketaniwaki@gmail.com> docs: Add JSON schema for IDE validation (argoproj#4581) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> refactor: Use polling model for workflow phase metric (argoproj#4557) Signed-off-by: Simon Behar <simbeh7@gmail.com> Addressing reviewers comments Signed-off-by: Alex Capras <alexcapras@gmail.com> Addressing reviewers comments docs: Minor typo fix (argoproj#4610) Signed-off-by: Paavo Pokkinen <paavo.pokkinen@vaimo.com> fix(controller): Prevent tasks with names starting with digit to use either 'depends' or 'dependencies' (argoproj#4598) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> fix(docs): Bring minio chart instructions up to date (argoproj#4586) Signed-off-by: Ranga Krishnan <ranga@bei.re> fix(executor): Fixed waitMainContainerStart returning prematurely. Closes argoproj#4599 (argoproj#4601) Signed-off-by: fsiegmund <siegmund@slb.com> feat(controller): Enhanced artifact repository ref. See argoproj#3184 (argoproj#4458) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: Null check pagination variable (argoproj#4617) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix: Perform fields filtering server side (argoproj#4595) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(server): Correct webhook event payload marshalling. Fixes argoproj#4572 (argoproj#4594) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(ui): Add columns--narrower-height to AttributeRow (argoproj#4371) fix: Fix TestCleanFieldsExclude (argoproj#4625) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(argo-server): fix global variable validation error with reversed dag.tasks (argoproj#4369) Signed-off-by: chenyu.zheng <chenyu.zheng@hulu.com> fix: derive jsonschema and fix up issues, validate examples dir… (argoproj#4611) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> fix(ui): Reference secrets in EnvVars. Fixes argoproj#3973 (argoproj#4419) Signed-off-by: Alejandro Tejera <aletepe@gmail.com> fix(ui): Fix Snyk issues (argoproj#4631) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(executor): More informative log when executors do not support output param from base image layer (argoproj#4620) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> Codegen patch. Signed off by alexcapras@gmail.com Codegen patch. Signed off by alexcapras@gmail.com Delete test.patch

Signed-off-by: github@finnesand.no <github@finnesand.no> feat(ui): Add Template/Cron workflow filter to workflow page. Closes argoproj#4532 (argoproj#4543) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> feat(executor): Auto create s3 bucket if not present. Signed-off-by: Alex Capras <alexcapras@gmail.com> Apply codegen Signed-off-by: Alex Capras <alexcapras@gmail.com> Add argo-e2e label to test wf Signed-off-by: Alex Capras <alexcapras@gmail.com> chore: Updated stress test YAML (argoproj#4569) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Updated kubectl apply command in manifests README (argoproj#4577) Signed-off-by: Stefan Gloutnikov <stefan@gloutnikov.com> feat(controller): Make MAX_OPERATION_TIME configurable. Close argoproj#4239 (argoproj#4562) Signed-off-by: Alex Collins <alex_collins@intuit.com> docs: Fix a typo in example (argoproj#4590) Signed-off-by: Takayoshi Nishida <takayoshi.nishida@gmail.com> feat(controller): Retry transient offload errors. Resolves argoproj#4464 (argoproj#4482) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix(server): use the correct name when downloading artifacts (argoproj#4579) Signed-off-by: Daniel Herman <dherman@factset.com> fix(server): serve artifacts directly from disk to support large artifacts (argoproj#4589) Signed-off-by: Daniel Herman <dherman@factset.com> fix(executor): Handle sidecar killing in a process-namespace-shared pod (argoproj#4575) Signed-off-by: Daisuke Taniwaki <daisuketaniwaki@gmail.com> docs: Add JSON schema for IDE validation (argoproj#4581) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> refactor: Use polling model for workflow phase metric (argoproj#4557) Signed-off-by: Simon Behar <simbeh7@gmail.com> Addressing reviewers comments Signed-off-by: Alex Capras <alexcapras@gmail.com> Addressing reviewers comments docs: Minor typo fix (argoproj#4610) Signed-off-by: Paavo Pokkinen <paavo.pokkinen@vaimo.com> fix(controller): Prevent tasks with names starting with digit to use either 'depends' or 'dependencies' (argoproj#4598) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> fix(docs): Bring minio chart instructions up to date (argoproj#4586) Signed-off-by: Ranga Krishnan <ranga@bei.re> fix(executor): Fixed waitMainContainerStart returning prematurely. Closes argoproj#4599 (argoproj#4601) Signed-off-by: fsiegmund <siegmund@slb.com> feat(controller): Enhanced artifact repository ref. See argoproj#3184 (argoproj#4458) Signed-off-by: Alex Collins <alex_collins@intuit.com> fix: Null check pagination variable (argoproj#4617) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix: Perform fields filtering server side (argoproj#4595) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(server): Correct webhook event payload marshalling. Fixes argoproj#4572 (argoproj#4594) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(ui): Add columns--narrower-height to AttributeRow (argoproj#4371) fix: Fix TestCleanFieldsExclude (argoproj#4625) Signed-off-by: Simon Behar <simbeh7@gmail.com> fix(argo-server): fix global variable validation error with reversed dag.tasks (argoproj#4369) Signed-off-by: chenyu.zheng <chenyu.zheng@hulu.com> fix: derive jsonschema and fix up issues, validate examples dir… (argoproj#4611) Signed-off-by: Paul Brabban <paul.brabban@gmail.com> fix(ui): Reference secrets in EnvVars. Fixes argoproj#3973 (argoproj#4419) Signed-off-by: Alejandro Tejera <aletepe@gmail.com> fix(ui): Fix Snyk issues (argoproj#4631) Signed-off-by: Alex Collins <alex_collins@intuit.com> feat(executor): More informative log when executors do not support output param from base image layer (argoproj#4620) Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> Codegen patch. Signed off by alexcapras@gmail.com Codegen patch. Signed off by alexcapras@gmail.com Delete test.patch Signed-off-by: Alex Capras <alexcapras@gmail.com>

simster7 · 2020-12-10T12:53:51Z

Back-ported to v2.12.0-RC5

Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

alexec reviewed Nov 22, 2020

View reviewed changes

docs/ide-setup.md Outdated Show resolved Hide resolved

alexec self-assigned this Nov 23, 2020

brabster commented Nov 23, 2020

View reviewed changes

alexec approved these changes Nov 24, 2020

View reviewed changes

brabster changed the title ~~WIP Append VSCode instructions - needs a stable schema URL~~ Append VSCode instructions - needs a stable schema URL Nov 24, 2020

alexec and others added 20 commits November 24, 2020 08:53

fix(controller): Correct default port logic (argoproj#4547)

f18d2b8

Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

docs: Update cost optimisation to include information about cleaning …

5a76dc0

…up workflows and archiving (argoproj#4549) Signed-off-by: Zach Brown <github@prozach.org> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

docs: Added CloudSeeds as one of the users for argo (argoproj#4553)

a2335ea

Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

fix: Respect continueOn for leaf tasks (argoproj#4455)

325d5f8

Signed-off-by: Simon Behar <simbeh7@gmail.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

fix: executor/pns containerid prefix fix (argoproj#4555)

93da1a0

Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

chore: Remove unused image build and push hooks (argoproj#4539)

337047b

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

docs: Clean-up examples. Fixes argoproj#4124 (argoproj#4128)

8dc491b

Signed-off-by: github@finnesand.no <github@finnesand.no> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

feat(ui): Add Template/Cron workflow filter to workflow page. Closes a…

b48996a

…rgoproj#4532 (argoproj#4543) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

chore: Updated stress test YAML (argoproj#4569)

1ecb59b

Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

docs: Updated kubectl apply command in manifests README (argoproj#4577)

3a4b20c

Signed-off-by: Stefan Gloutnikov <stefan@gloutnikov.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

feat(controller): Make MAX_OPERATION_TIME configurable. Close argopro…

bf38cb2

…j#4239 (argoproj#4562) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Append VSCode instructions - needs a stable schema URL

44df788

Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Add IDEA instructions, move CRD-based instructions to the bottom and …

18dab75

…warn Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

feat: Add JSON schema. Closes argoproj#4477

81779db

Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

js: M api/jsonschema/schema.json

3108998

Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

js: M hack/swagger/secondaryswaggergen.go

835ffa5

Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

js: M api/jsonschema/schema.json

667c33c

Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

js: M hack/swagger/kubeifyswagger.go

37ba277

Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Remove unneeded CRD-based IDE setup

41f4918

Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Update link to JSON schema

beeef6b

Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

brabster force-pushed the ide-support-vscode branch from 5812193 to beeef6b Compare November 24, 2020 08:54

alexec changed the title ~~Append VSCode instructions - needs a stable schema URL~~ docs: Add JSON schema for IDE validation Nov 24, 2020

Merge branch 'master' into ide-support-vscode

3394a13

alexec merged commit 99240ad into argoproj:master Nov 24, 2020

alexec added this to the v3.0 milestone Nov 24, 2020

simster7 pushed a commit that referenced this pull request Dec 10, 2020

docs: Add JSON schema for IDE validation (#4581)

20f59de

Signed-off-by: Paul Brabban <paul.brabban@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Add JSON schema for IDE validation #4581

docs: Add JSON schema for IDE validation #4581

brabster commented Nov 21, 2020 •

edited

Loading

CLAassistant commented Nov 21, 2020 •

edited

Loading

brabster left a comment

brabster Nov 23, 2020

alexec commented Nov 24, 2020

alexec left a comment

alexec commented Nov 24, 2020

brabster commented Nov 24, 2020

alexec commented Nov 24, 2020

simster7 commented Dec 10, 2020

docs: Add JSON schema for IDE validation #4581

docs: Add JSON schema for IDE validation #4581

Conversation

brabster commented Nov 21, 2020 • edited Loading

CLAassistant commented Nov 21, 2020 • edited Loading

brabster left a comment

Choose a reason for hiding this comment

brabster Nov 23, 2020

Choose a reason for hiding this comment

alexec commented Nov 24, 2020

alexec left a comment

Choose a reason for hiding this comment

alexec commented Nov 24, 2020

brabster commented Nov 24, 2020

alexec commented Nov 24, 2020

simster7 commented Dec 10, 2020

brabster commented Nov 21, 2020 •

edited

Loading

CLAassistant commented Nov 21, 2020 •

edited

Loading